sketching on a mirror2d thats been extruded fixed!

[jessfraz]

fixes #4962

thank you @gserena01

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
modeling-app	✅ Ready (Inspect)	Visit Preview	Apr 4, 2025 7:43pm

[codspeed-hq]

CodSpeed Walltime Performance Report

Merging #6149 will degrade performances by 19.26%

_{Comparing sketch-on-mirror (4d4cb8c) with main (96e12b5)}

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 6 improvements
❌ 6 regressions
✅ 78 untouched benchmarks
🆕 2 new benchmarks
⁉️ 2 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	execute_80-20-rail	3.4 s	3.9 s	-13.16%
⁉️	execute_a-parametric-bearing-pillow-block	2.7 s	N/A	N/A
⁉️	parse_a-parametric-bearing-pillow-block	1.8 ms	N/A	N/A
❌	execute_exhaust-manifold	2.1 s	2.4 s	-13.06%
❌	execute_focusrite-scarlett-mounting-bracket	2.2 s	2.4 s	-11%
⚡	execute_gridfinity-baseplate-magnets	5.6 s	5 s	+12.32%
❌	execute_gridfinity-baseplate	2.7 s	3.1 s	-10.61%
❌	execute_i-beam	1.1 s	1.4 s	-19.26%
⚡	execute_lego	3.1 s	2.5 s	+23.09%
🆕	execute_parametric-bearing-pillow-block	N/A	2.8 s	N/A
🆕	parse_parametric-bearing-pillow-block	N/A	1.8 ms	N/A
❌	execute_pipe-flange-assembly	5.2 s	5.9 s	-13.16%
⚡	parse_pipe	906.3 µs	408.5 µs	×2.2
⚡	execute_socket-head-cap-screw	1.9 s	1.7 s	+10.14%
⚡	parse_walkie-talkie	899.4 µs	806.1 µs	+11.58%
⚡	parse_washer	707.2 µs	517.8 µs	+36.56%

[codecov]

Codecov Report

Attention: Patch coverage is 67.56757% with 12 lines in your changes missing coverage. Please review.

Project coverage is 85.34%. Comparing base (a789632) to head (4d4cb8c).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
rust/kcl-lib/src/std/mirror.rs	71.42%	8 Missing ⚠️
rust/kcl-lib/src/std/extrude.rs	50.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6149      +/-   ##
==========================================
- Coverage   85.39%   85.34%   -0.05%     
==========================================
  Files         110      110              
  Lines       44215    44246      +31     
==========================================
+ Hits        37756    37763       +7     
- Misses       6459     6483      +24     

Flag	Coverage Δ
rust	85.34% <67.56%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.