Remove the camera projection toggle from the UI#6077
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6077 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 110 110
Lines 44215 44215
=======================================
Hits 37750 37750
Misses 6465 6465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Even though the test is `fixme`'d this should make it easier to ressurect. The test is still flaky but it runs now.
franknoirot
force-pushed
the
franknoirot/adhoc/remove-projection-toggle
branch
from
cc1e508 to
13124e7
Compare
| homePage, | ||
| toolbar, | ||
| }) => { | ||
| test.fixme(orRunWhenFullSuiteEnabled()) |
There was a problem hiding this comment.
This test is being skipped on PRs, so the changes you made to it won't have run on CI. You might consider removing this line if you've made the test more reliable and would like it to run.
There was a problem hiding this comment.
I'm down to try it! I was just concerned with removing all references to this toggle from the code base, so I saw this as making a future attempt to turn that test back on a little less confusing. I don't think that I've made the test more reliable but I can see.
|
FYI this will be accessible via the file menu in this PR #6030 |
|
this one might be real Testing Gizmo › check top view |
|
I'll take a look and get this in today |
|
Ugh we just blindly pixel click in those tests because the gizmo has no elements to grab onto, so removing a completely unrelated element bricks those tests because it moved the gizmo. Lame. |
* Remove E2E test behavior for projection toggle UI Even though the test is `fixme`'d this should make it easier to ressurect. The test is still flaky but it runs now. * Remove projection toggle from the UI
* origin/main: (26 commits) attempt to import win-ca on windows (#6136) Upgrade e2e-tests windows runner from 4 cores to 8 (#6166) Follow-up fixes after bearing sample rename (#6164) Add test for #5799: "Only showing axis planes when there are no errors" (#6007) Wait for export button to make test more reliable (#6143) sketching on a mirror2d thats been extruded fixed! (#6149) Bump vite from 5.4.16 to 5.4.17 in /packages/codemirror-lang-kcl in the security group (#6150) Bump vite from 5.4.16 to 5.4.17 in the security group (#6151) Update all KCL-Samples to be more ME friendly (#6132) Shorten feedback cycle for legitimate failures (#6146) Remove the camera projection toggle from the UI (#6077) Use all available CPUs to run tests on CI (#6138) [fix] Get rid of risky useEffect in restart onboarding flow (#6133) Feature: Traditional menu actions in desktop application part II (#6030) [Bug] fix some UI friction from imports (#6139) Use scene fixture to make test more reliable on macOS (#6140) Fix: function composition during playwright setup created a massive page.reload loop (#6137) Alternative way to make appMachine spawned children type safe (#5890) [BUG] mutate ast to keep comments for pipe split ast-mod (#6128) Rename the app to Zoo Design Studio (#5974) ...
5 participants
During a recent "final appearance tweaks" meeting we came to the agreement with our in-house mechanical designers @jgomez720, @nicboone8, and @nickmccleery that he camera projection toggle is not something that matters much to CAD users, so we're going to remove the toggle button from the lower-right controls and make that area just a little bit more simple. The camera projection is still adjustable under user settings, so it hasn't gone away.
Current:
New:
