[Bug] fix some UI friction from imports#6139
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6139 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 110 110
Lines 44215 44215
=======================================
Hits 37750 37750
Misses 6465 6465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (fileIndex !== 0) { | ||
| const importDetails = | ||
| kclManager.execState.filenames[fileIndex] | ||
| if (importDetails?.type === 'Local') { |
There was a problem hiding this comment.
I wanted to check with the kcl oracles if I should checking anything else here, there's main and std but main is the happy path, and we std is not ever geometry right?
there might one day be url or similar, but can probably update at the time?
There was a problem hiding this comment.
That's correct. I don't think anything restricts std from having geometry, but we don't currently.
If you'd like the addition of a new case to fail tsc, you can make an exhaustive check like this:
modeling-app/src/lib/operations.ts
Line 1126 in d270447
* fix some UI friction from imports * add test * console * Jon's comments
* fix some UI friction from imports * add test * console * Jon's comments
* fix some UI friction from imports * add test * console * Jon's comments
* fix some UI friction from imports * add test * console * Jon's comments
| const fileIndex = getModuleId(extrusion.codeRef.range) | ||
| if (fileIndex !== 0) { |
There was a problem hiding this comment.
One nitpick. We can use isTopLevelModule() here too.
| const fileIndex = getModuleId(extrusion.codeRef.range) | |
| if (fileIndex !== 0) { | |
| if (!isTopLevelModule(extrusion.codeRef.range)) { | |
| const fileIndex = getModuleId(extrusion.codeRef.range) |
* fix some UI friction from imports * add test * console * Jon's comments
* origin/main: (26 commits) attempt to import win-ca on windows (#6136) Upgrade e2e-tests windows runner from 4 cores to 8 (#6166) Follow-up fixes after bearing sample rename (#6164) Add test for #5799: "Only showing axis planes when there are no errors" (#6007) Wait for export button to make test more reliable (#6143) sketching on a mirror2d thats been extruded fixed! (#6149) Bump vite from 5.4.16 to 5.4.17 in /packages/codemirror-lang-kcl in the security group (#6150) Bump vite from 5.4.16 to 5.4.17 in the security group (#6151) Update all KCL-Samples to be more ME friendly (#6132) Shorten feedback cycle for legitimate failures (#6146) Remove the camera projection toggle from the UI (#6077) Use all available CPUs to run tests on CI (#6138) [fix] Get rid of risky useEffect in restart onboarding flow (#6133) Feature: Traditional menu actions in desktop application part II (#6030) [Bug] fix some UI friction from imports (#6139) Use scene fixture to make test more reliable on macOS (#6140) Fix: function composition during playwright setup created a massive page.reload loop (#6137) Alternative way to make appMachine spawned children type safe (#5890) [BUG] mutate ast to keep comments for pipe split ast-mod (#6128) Rename the app to Zoo Design Studio (#5974) ...
2 participants
Screenshare.-.2025-04-04.3_43_30.PM.mp4