feat(mobile): add Manage Profiles and profile picker at web parity

[iscekic]

Changelog for users

• Browse, create, edit, and delete profiles from the Profile tab.
• Pick a profile at session start, including the "No profile" choice.
• Change the profile from Advanced Configuration while starting a session.
• See the active profile as a chip on the new-session and session screens.
• Save the current environment variables and setup commands as a new profile, or edit an existing one.
• Edit a profile's variables, setup commands, slash commands, MCP servers, skills, and agents.
• Keep secret values masked until revealed, and enter a new value to rotate one.
• Manage personal and organization profiles and repository bindings; reorder with up/down buttons, never drag.
• Tapping the active-profile chip in an organization session opens the profile in its own owner's scope.
• Editing an MCP server keeps its stored type, so remote headers and masked secrets stay intact.
• Deleting a skill's frontmatter description now clears the stored description.
• Text typed while the setup-command list refreshes is no longer dropped.
• Marking a profile as the default updates the right owner and the effective default.
• The web sidebar and survey no longer show signed-out after a temporary server error.
• Profile rows show the MCP server count in place of the setup-command count.
• Save as Profile appears only after a setup command has text.
• The variable delete control is disabled while a delete is in progress.
• The repository-binding profile picker explains when the context has no profiles.
• Adding a variable whose key normalizes to an existing key is refused with an inline error instead of overwriting the stored variable.
• Editing an MCP server keeps command arguments that contain spaces intact.
• Manual environment variables and setup commands entered under Advanced Configuration are sent with the new session, even without saving a profile first.
• The MCP server form reports over-limit commands, URLs, and environment or header JSON before saving.
• Switching organization no longer briefly shows the previous organization's profiles.
• Segmented-control labels wrap instead of being truncated to one line.

Changelog for maintainers

• Mobile's tRPC mount now exposes every profile-management procedure; each reuses the web router's own auth and organization-access checks, so the mount adds no server behavior.
• Personal and organization ownership follows web: a personal create never carries the selected organization, and an org-owned profile's reads and writes carry organizationId.
• Removed renderProfileRow; NewSessionProfileRow replaces it and requires onOpenProfilePicker, selectedProfileId, onSelectProfile, and profileOverrideNeedsAttention.
• The new-session profile pick is session state shared by the Environment row and the advanced-config selector; it drives the submitted profileId, and a stale pick reports attention without submitting.
• The web picker now renders loading and error states plus a "No profile" row, so a pending or failed profile list no longer looks empty.
• The catalog checker now requires translated strings to preserve $TOKEN expansion tokens; the allowlist adds literal profile examples (command, MCP, slug, and slash-command placeholders, top_p, and the MCP count).
• The web app's typecheck script now passes a TS build-info file flag; this is a build-cache change, not a dependency or policy exception.
• Platform check refuted: the flagged added lines import expo-router and react-native-safe-area-context, both cross-platform, and the diff adds no Platform.OS/Platform.select/.ios/.android branch.
• Live-device platform proof is unavailable on this host: the shared mobile checks (typecheck, unit, i18n, unused) passed, and the iOS live check is skipped, pending owner verification.
• The duplicate-key and MCP-bound messages are in the English catalog and every locale catalog; the catalog-parity checker allowlists the four keys as pending translation.
• Removed the unused Android-only destructive-confirm selector; RTL tracked-label handling and segmented-control label wrapping were adjusted, and the affected mounted suites stub platform and safe-area modules.
• The E2E proof keeps the picker and sidebar runtime captures, the dev-stack profile editor/CRUD capture, and the browser smoke that rendered the profile page under fake auth; the refreshed run log excerpts replace the earlier inline picker/CRUD excerpt.
• apps/mobile/src/components/agents/session-detail-content.tsx:488 — accepted: the chip now resolves the profile's owner scope, so an org session opens a personal default in personal scope; EffectiveAgentProfile carries ownerType for the choice.
• apps/mobile/src/components/profiles/mcp-form-sheet.tsx:118 — accepted: the local/remote selector renders only for a new server, so editing cannot re-envelope the stored config as the other type.
• apps/mobile/src/components/profiles/skill-form-sheet.tsx:69 — accepted: the skills update now sends description: null when the frontmatter omits it, so clearing persists server-side.
• apps/mobile/src/components/profiles/profile-commands-screen.tsx:89 — accepted: the refetch sync skips while a save is pending and only swaps a clean list, bumping generation so remounted fields show server truth; in-flight drafts survive.
• apps/mobile/src/lib/hooks/use-agent-profile-mutations.ts:97 — accepted: optimistic default writes touch only the mutated owner and recompute the effective default personal-first; clearDefault passes the profile id and list/detail caches are keyed by input.
• apps/web/src/app/(app)/components/PrefetchedOrganizations.tsx:40 — accepted: ['user'] is seeded only for a resolved user, so a failed context no longer pins signed-out for the global staleTime.
• apps/mobile/src/components/profiles/profile-list-model.ts:109 — accepted: the row subtitle uses mcpServerCount and emits MCP in web order (vars, MCP, skills).
• apps/mobile/src/components/agents/advanced-config-panel.tsx:154 — accepted: hasManualConfig uses the trimmed commands that are actually persisted, so a blank draft row no longer offers Save as Profile.
• apps/mobile/src/components/profiles/profile-variables-screen.tsx:105 — accepted: delete is guarded and the row's delete control is disabled while the mutation is pending.
• apps/mobile/src/components/profiles/repo-bindings-profile-sheet.tsx:57 — accepted: the picker renders an empty state when the context has no profiles.
• apps/mobile/src/components/profiles/profile-variables-rows.tsx:186 — accepted: a new key is normalized with cleanVariableKey and refused when it matches a stored key, so the server's (profile_id, key) upsert can no longer silently replace a variable; the variables screen and the manual-vars editor pass their existing keys.
• apps/mobile/src/components/profiles/profile-mcp-model.ts:112 — accepted: formatCommand quotes and escapes an argument holding whitespace, a quote, or a backslash, and commandParts parses it back, so an unedited ['tool', '--label=foo bar'] round-trips; a round-trip test covers it.
• apps/mobile/src/components/agents/advanced-config-panel.tsx:257 — accepted: the manual env-var and setup-command draft now lives in the new-session route, the panel only reports changes, and the create carries envVars/setupCommands (omitted when empty) in the prepare-session body and intent fingerprint.
• apps/mobile/src/components/profiles/profile-mcp-model.ts:187 — accepted: validateMcpForm mirrors the server bounds — 50 command arguments of 500 characters, a 2048-character URL, and 50 env/header entries with 128-character keys and 4096-character values — and surfaces the field error before the mutation.
• apps/mobile/src/lib/hooks/use-agent-profiles.ts:40 — accepted: a key-aware placeholder replaces keepPreviousData, returning previous rows only when the query key is unchanged, so an organization switch starts empty while a same-key refetch keeps the list; a context-switch test covers it.

E2E proof

E2E proof — log excerpts

[e1] Web parity: Manage Profiles — picker, editor, ownership (owner request B, P -> pass :: Web reference surfaces live on port 7400: picker popover shows the new 'No profile' row plus 'e1 web parity'/'1 vars' (e1-cloud-githubuser.log: 'PICK A PROFILE' / 'No profile'); loading branch shows 'Loading profiles…' and error branch 'Could not load profiles.' with 'Retry' under a stubbed agentProfiles.list 500 (e1-picker-loading.log, e1-picker-error.log); Manage Profiles dialog renders Overview/Variables 1/Setup 0/Slash Cmds 0/MCP 0/Skills 0/Agents 0 plus 'Pinned to repositories' and 'iscekic/cloud GITHUB' (e1-manage.log); selecting a profile updates the row to 'e1 web parity · 1 vars' and the popover to 'ACTIVE PROFILE' (e1-select.log); org selector and org pair seed present (e1-org.log

Session profile id end to end (review thread PRRT_kwDORD_mN86lphlV)

The session-detail chip showed the context's effective default, not the profile the session was prepared with. The resolved profile id is now persisted at create and read back by the chip.

Layer	Change
DB	packages/db/src/schema.ts:6376 nullable cli_sessions_v2.profile_id (ON DELETE SET NULL); migration packages/db/src/migrations/0258_cynical_vapor.sql
Contract	packages/session-ingest-contracts/src/rpc-contract.ts:144 optional/nullable profileId on the create payload
Ingest	services/session-ingest/src/session-ingest-rpc.ts:320 writes profile_id on the root insert
Resolve	packages/cloud-agent-profile/src/profile-session-config.ts:111,361 reports the resolved active profile id; services/cloud-agent-next/src/router/handlers/session-prepare.ts:168 carries it; services/cloud-agent-next/src/session/session-registration.ts:776,1880,1976 pass it; services/cloud-agent-next/src/session-service.ts:3031 sends it
SDK	packages/cloud-agent-sdk/src/session-manager.ts:292 FetchedSessionData.profileId
Adapters	apps/mobile/src/components/agents/mobile-session-manager.ts:468, apps/extension/src/shared/extension-agent-session-manager.ts:618; read surface apps/web/src/routers/cli-sessions-v2-router.ts:1556,1682
Chip	apps/mobile/src/components/agents/session-detail-content.tsx:516-533 resolves the recorded id, default only when the session recorded none

Pushed head: 508fa194058761aed05d58dc9e21cb356136df1f

Test commands and decisive output

POSTGRES_URL=postgresql://unused:unused@localhost:5432/unused pnpm drizzle check
Everything's fine 🐶🔥

pnpm --filter cloudflare-session-ingest test
Test Files  31 passed (31) | Tests  1135 passed | 3 skipped (1138)

pnpm --filter cloud-agent-next exec vitest run src/session-prepare.test.ts src/session-service.test.ts src/router/handlers/session-prepare.test.ts
Test Files  3 passed (3) | Tests  300 passed (300)

pnpm --filter kilo-app exec vitest run src/components/agents/session-detail-content.test.ts src/components/agents/mobile-session-manager.test.ts
Test Files  2 passed (2) | Tests  173 passed (173)

pnpm --filter @kilocode/cloud-agent-sdk typecheck        # tsgo --noEmit, clean
pnpm --filter kilo-app typecheck                          # tsgo --noEmit, clean
pnpm --filter web typecheck                               # tsgo --noEmit, clean
pnpm --filter kilo-extension typecheck                    # tsc --noEmit, clean

After merging origin/main (main holds 0258/0259), the migration is now packages/db/src/migrations/0260_complex_smasher.sql; re-verified on e2173db90a — drizzle check fine, db 34 passed, session-ingest 1153 passed / 3 skipped, cloud-agent-next prepare+create 302 passed, mobile session-detail + session-manager 176 passed, all touched-package typechecks clean.

---

CI repair at a6a285da63

Two checks failed at 1d431aea77. Both came from this branch's own change, not from a flake.

• cloud-agent-next — the profile-id change added profileId as the sixth argument of createCliSessionViaSessionIngest. That shifted every later argument, and src/session/session-prepare.test.ts pins them. The file now carries the new argument: 12 positional assertions and 3 arity checks agree with the call.
• test (kilo-app) and test (the kilo-app CI workflow) — repo-picker-sheet.tsx rendered a raw single-line TextInput. main's single-line-input-guard requires the shared box. The field now renders @/components/ui/input, the box language-picker-sheet.tsx uses for the same pill.

Proof at a6a285da63:

Check	Result
src/session/session-prepare.test.ts	288 passed (288)
cloud-agent-next package suite	252 files, 7649 passed, 3 skipped
single-line-input-guard.test.ts	20 passed (20)
mobile tsgo --noEmit	exit 0
oxlint, the mobile change	0 warnings, 0 errors
oxfmt --list-different	no file differs

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The incremental diff at c4f73b2fc adds I18nManager: { isRTL: false } to the react-native mocks of the two mounted profile tests, matching the established pattern used by the other mounted suites; the mocked prop is sufficient for the @/components/ui/text reads in those trees, and no new defects were found.

Files Reviewed (2 files)

• apps/mobile/src/components/profiles/profile-repo-pins-section.mounted.test.tsx
• apps/mobile/src/components/profiles/repo-bindings-screen.mounted.test.tsx

Previous Review Summaries (10 snapshots, latest commit a6a285d)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit a6a285d)

Status: No Issues Found | Recommendation: Merge

Executive Summary

The incremental diff at a6a285da63 routes the repo-picker search field through the shared Input and realigns the profileId positional assertions; both changes are correct and consistent with existing patterns.

Files Reviewed (2 files)

• apps/mobile/src/components/profiles/repo-picker-sheet.tsx
• services/cloud-agent-next/src/session/session-prepare.test.ts

Previous review (commit 1d431ae)

Status: No Issues Found | Recommendation: Merge

The incremental change builds IDX_cli_sessions_v2_profile_id concurrently, resolving the prior lock warning; schema, migration, and snapshot are consistent and follow the repository's documented concurrent-index pattern.

Files Reviewed (4 files)

• packages/db/src/schema.ts
• packages/db/src/migrations/0260_free_amazoness.sql
• packages/db/src/migrations/meta/_journal.json (generated)
• packages/db/src/migrations/meta/0260_snapshot.json (generated)

Previous review (commit c448248)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The two commits since the previous review resolve both prior findings - the restored session-chip error layer and the missing profile_id index - but the new index is created non-concurrently on the large cli_sessions_v2 table, which locks writes for the build.

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

WARNING

File	Line	Issue
packages/db/src/schema.ts	6428	New IDX_cli_sessions_v2_profile_id is declared without .concurrently(), so the generated migration builds it with a write-blocking lock on the large cli_sessions_v2 table

Files Reviewed (5 files, 2 generated)

• apps/mobile/src/components/agents/session-detail-content.tsx - prior unused-binding finding resolved (hasProfileError: isSessionProfileError restored); new current-row guard is correct
• packages/db/src/schema.ts - prior missing-index finding resolved; 1 new concurrent-build issue
• packages/db/src/migrations/0260_misty_gabe_jones.sql - plain CREATE INDEX (see schema finding)
• packages/db/src/migrations/meta/_journal.json (generated)
• packages/db/src/migrations/meta/0260_snapshot.json (generated)

Fix these issues in Kilo Cloud

Previous review (commit 508fa19)

Status: 2 Issues Found | Recommendation: Address before merge

Executive Summary

The recorded-profile plumbing is wired correctly end to end, but the mobile session-detail refactor leaves a dead binding that fails pnpm lint, and the new cli_sessions_v2.profile_id foreign key ships without a supporting index.

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	1

Issue Details (click to expand)

WARNING

File	Line	Issue
apps/mobile/src/components/agents/session-detail-content.tsx	514	isSessionProfileError is now unused after hasProfileError was dropped; oxlint no-unused-vars fails pnpm lint

SUGGESTION

File	Line	Issue
packages/db/src/schema.ts	6376	New profile_id FK (ON DELETE set null) has no supporting index; profile deletion scans the large cli_sessions_v2 table

Files Reviewed (22 files, 2 generated)

• apps/extension/src/shared/extension-agent-session-manager.ts
• apps/mobile/src/components/agents/mobile-session-manager.ts
• apps/mobile/src/components/agents/session-detail-content.test.ts
• apps/mobile/src/components/agents/session-detail-content.tsx - 1 issue
• apps/web/src/routers/cli-sessions-v2-router.ts
• apps/web/src/routers/cli-sessions-v2-worktree.test.ts
• apps/web/src/tests/cloud-agent-profile/profile-session-config.test.ts
• packages/cloud-agent-profile/src/profile-session-config.ts
• packages/cloud-agent-sdk/src/session-manager.ts
• packages/db/src/migrations/0258_cynical_vapor.sql
• packages/db/src/migrations/meta/_journal.json (generated)
• packages/db/src/migrations/meta/0258_snapshot.json (generated)
• packages/db/src/schema.ts - 1 issue
• packages/session-ingest-contracts/src/rpc-contract.ts
• services/cloud-agent-next/src/router/handlers/session-prepare.ts
• services/cloud-agent-next/src/session-prepare.test.ts
• services/cloud-agent-next/src/session-service.test.ts
• services/cloud-agent-next/src/session-service.ts
• services/cloud-agent-next/src/session/session-registration.ts
• services/cloud-agent-next/src/session/session-requests.ts
• services/session-ingest/src/session-ingest-rpc.test.ts
• services/session-ingest/src/session-ingest-rpc.ts

Fix these issues in Kilo Cloud

Previous review (commit f6b8270)

Status: No Issues Found | Recommendation: Merge

Executive Summary

The incremental commit f6b8270f5 (three profile-picker/profile-save fixes) was reviewed against its changed lines; the label, draft-clearing, and bound changes are correct and no new defects were found.

Files Reviewed (11 files)

• apps/mobile/src/app/(app)/agent-chat/profile-picker.tsx
• apps/mobile/src/components/agents/advanced-config-editors.tsx
• apps/mobile/src/components/agents/advanced-config-panel.tsx
• apps/mobile/src/components/agents/advanced-config-panel.mounted.test.tsx
• apps/mobile/src/components/agents/profile-picker-sheet.tsx
• apps/mobile/src/components/agents/profile-picker-sheet.mounted.test.tsx
• apps/mobile/src/components/agents/profile-selector-model.ts
• apps/mobile/src/components/agents/profile-selector-model.test.ts
• apps/mobile/src/components/agents/profile-selector-row.tsx
• apps/mobile/src/components/profiles/profile-variables-rows.tsx
• apps/mobile/src/lib/agent-profile-forms.ts

Previous review (commit 794d8cf)

Status: No Issues Found | Recommendation: Merge

Executive Summary

The incremental changes since 8b3b33fa2 resolve all six prior findings and add focused tests; no new issues were found in the changed code.

Files Reviewed (18 files)

• apps/mobile/src/components/agents/advanced-config-editors.tsx - setup-command list/row bounds added, no issues
• apps/mobile/src/components/agents/advanced-config-panel.mounted.test.tsx - cap test, no issues
• apps/mobile/src/components/profiles/kilo-command-form-sheet.tsx - name/description/template maxLength, no issues
• apps/mobile/src/components/profiles/kilo-command-form-sheet.mounted.test.tsx - bound test, no issues
• apps/mobile/src/components/profiles/profile-agents-model.ts - variant retention fix, no issues
• apps/mobile/src/components/profiles/profile-agents-model.test.ts - variant tests, no issues
• apps/mobile/src/components/profiles/profile-commands-model.ts - re-exports bounds, no issues
• apps/mobile/src/components/profiles/profile-commands-model.test.ts - cap test, no issues
• apps/mobile/src/components/profiles/profile-commands-screen.tsx - maxLength + add cap, no issues
• apps/mobile/src/components/profiles/profile-kilo-commands-model.ts - server bound constants, no issues
• apps/mobile/src/i18n/catalog-parity.test.ts - pending-translation set emptied; all four keys verified present in all 87 catalogs
• apps/mobile/src/lib/agent-profile-forms.ts - MAX_SETUP_COMMANDS/MAX_SETUP_COMMAND_LENGTH, add cap, no issues
• apps/mobile/src/lib/agent-profile-forms.test.ts - cap test, no issues
• apps/mobile/src/lib/hooks/use-agent-profiles.ts - exported key-aware placeholder, no issues
• apps/mobile/src/lib/hooks/use-repo-bindings.ts - key-aware placeholder replaces keepPreviousData, no issues
• apps/mobile/src/lib/hooks/use-repo-bindings.mounted.test.tsx - context-switch test, no issues
• apps/web/src/components/cloud-agent/ProfilePickerPopover.tsx - error state now requires empty cache, no issues
• apps/web/src/components/cloud-agent/ProfilePickerPopover.test.ts - cached-error test, no issues

Previously reported findings re-verified resolved at 794d8cfd0: agent effort-variant retention, repo-bindings cross-scope placeholder, picker error-with-cached-data, kilo-command and setup-command server bounds, and the stale pending-translation allowlist. No memory-leak patterns were found in the changed code.

Previous review (commit 8b3b33f)

Status: 6 Issues Found | Recommendation: Address before merge

Executive Summary

The rebase (previous reviewed SHA by force-push/rewrite) carried over every earlier accepted fix, and this pass on the current single-commit diff (b9007d12b..8b3b33fa2, 221 files) raised six new issues: a stale-data/cross-scope placeholder in the repo-bindings hook, a dropped agent effort variant, an error branch that hides cached web profiles, and three client/server bound-parity gaps.

Overview

Severity	Count
CRITICAL	0
WARNING	3
SUGGESTION	3

Issue Details (click to expand)

WARNING

File	Line	Issue
apps/mobile/src/components/profiles/profile-agents-model.ts	273	Changing an agent's model discards an effort variant the new model supports (existing.model === model guard).
apps/mobile/src/lib/hooks/use-repo-bindings.ts	30	Raw keepPreviousData leaks the previous organization's bindings across an org switch while mutations use the new scope.
apps/web/src/components/cloud-agent/ProfilePickerPopover.tsx	402	isError is !!error, so a failed background refetch hides the picker even though cached profiles are present.

SUGGESTION

File	Line	Issue
apps/mobile/src/components/profiles/profile-kilo-commands-model.ts	138	Validation omits the server's name (50) / template (100k) / description (2k) length bounds.
apps/mobile/src/components/agents/advanced-config-editors.tsx	209	Setup-commands editor is unbounded while prepareSession/setCommands cap 20 commands of 500 chars.
apps/mobile/src/i18n/catalog-parity.test.ts	34	The four allowlisted keys already exist (translated) in every catalog, so the pending-translation set is stale.

Files Reviewed (221 files)

All 221 files in the current PR diff (b9007d12b..8b3b33fa2). Substantive source reviewed in full: the mobile profile screens, models, sheets, rows and pickers under apps/mobile/src/components/profiles/; the agents feature (advanced-config-panel, advanced-config-editors, save-profile-sheet, profile-picker-sheet, profile-selector-*, active-profile-indicator, new-session-*, session-detail-content, use-effective-agent-profile, use-new-session-creator); the hooks and libs (use-agent-profile-mutations, use-agent-profile-section-mutations, use-agent-profiles, use-repo-bindings, agent-profile-forms, profile-count-labels, profile-agent-navigation, picker-bridge, route-registry, prepare-agent-session); the (3_profile) routes; the web surfaces (PrefetchedOrganizations, SeedUserQuery, (app)/layout, ProfilePickerPopover, TriggerForm); packages/trpc/src/agent-profiles-mobile.ts; and tools/i18n/check-catalogs.mjs. The remaining files are locale catalogs and test/helper files spot-checked for key parity and placeholder integrity.

Previously reported findings re-verified resolved at HEAD: owner-scope chip, MCP edit type lock, skill description clearing, commands refetch generation, owner-scoped optimistic defaults, ['user'] seeding, profile-list MCP count, manual-commands gate, variables delete guard, repo-bindings empty state, duplicate-key normalization, MCP command quoting, manual env/command propagation into the create body, MCP form bounds, and the key-aware profile-list placeholder. The one rejected item (numeric expansion tokens in check-catalogs.mjs) remains unchanged by owner decision.

No memory-leak patterns (uncleared timers, listeners, subscriptions, or retained bridge state) were found in the added code.

Fix these issues in Kilo Cloud

Previous review (commit cd3af0d)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review at HEAD cd3af0d73: the rebase onto current main introduced no new PR code — the only content deltas since the last-reviewed tree (b0460cef9) are adoptions of already-merged main changes (tool-summary retry mount wiring, a test secure-store mock, a passkey case-guard rewrap, and openSession/approveFailed locale keys from merged PRs), and every previously accepted fix was verified present at the current tree; no memory-leak patterns were found in the added lines.

Files Reviewed (217 files)

• All 217 files in the current PR diff (f5e3cf7 → cd3af0d) were verified byte-identical to the last-reviewed tree for every profile-management file (screens, sheets, models, hooks, tRPC mount, tests, web components), except four groups whose head-to-head deltas come solely from rebase adoption of merged main content: (app)/_layout.tsx, session-detail-queue.test.ts, case-guard.test.ts, and the locale catalogs. Previously raised findings are all resolved: ten accepted fixes verified at current HEAD (session-detail-content owner-scope chip, mcp-form-sheet edit-locked type, skill description clearing, commands refetch sync with generation bump, owner-scoped optimistic defaults, PrefetchedOrganizations user seeding, profile-list-model MCP count, advanced-config manual-commands gate, variables delete guard, repo-bindings empty state) and one rejected by the owner (i18n numeric expansion tokens, no change requested).

Previous review

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of the profile-management fix set at HEAD b0460cef9 (96fe3c6 is not an ancestor, so each fix hunk was verified against the current tree); no new defects were found.

Files Reviewed (27 files)

• apps/mobile/src/app/(app)/_layout.tsx
• apps/mobile/src/components/agents/advanced-config-panel.mounted.test.tsx
• apps/mobile/src/components/agents/advanced-config-panel.tsx
• apps/mobile/src/components/agents/session-detail-content.test.ts
• apps/mobile/src/components/agents/session-detail-content.tsx
• apps/mobile/src/components/agents/session-detail-queue.test.ts
• apps/mobile/src/components/agents/use-effective-agent-profile.ts
• apps/mobile/src/components/profiles/mcp-form-sheet.tsx
• apps/mobile/src/components/profiles/profile-commands-screen.mounted.test.tsx
• apps/mobile/src/components/profiles/profile-commands-screen.tsx
• apps/mobile/src/components/profiles/profile-list-model.test.ts
• apps/mobile/src/components/profiles/profile-list-model.ts
• apps/mobile/src/components/profiles/profile-mcp-screen.mounted.test.tsx
• apps/mobile/src/components/profiles/profile-skills-screen.mounted.test.tsx
• apps/mobile/src/components/profiles/profile-skills-screen.tsx
• apps/mobile/src/components/profiles/profile-variables-rows.tsx
• apps/mobile/src/components/profiles/profile-variables-screen.mounted.test.tsx
• apps/mobile/src/components/profiles/profile-variables-screen.tsx
• apps/mobile/src/components/profiles/profiles-list-screen.mounted.test.tsx
• apps/mobile/src/components/profiles/repo-bindings-profile-sheet.mounted.test.tsx
• apps/mobile/src/components/profiles/repo-bindings-profile-sheet.tsx
• apps/mobile/src/lib/case-guard.test.ts
• apps/mobile/src/lib/hooks/use-agent-profile-mutations.ts
• apps/mobile/src/lib/hooks/use-agent-profiles.mounted.test.tsx
• apps/web/package.json
• apps/web/src/app/(app)/components/PrefetchedOrganizations.test.ts
• apps/web/src/app/(app)/components/PrefetchedOrganizations.tsx

Previous review (commit 96fe3c6)

Status: 11 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	6
SUGGESTION	5

Issue Details (click to expand)

WARNING

File	Line	Issue
apps/mobile/src/components/agents/session-detail-content.tsx	488	Active-profile chip opens a personal profile with the session organization scope, so the editor screen errors
apps/mobile/src/components/profiles/mcp-form-sheet.tsx	118	Editable type toggle on an existing MCP server can reinterpret masked env/headers and lose secrets
apps/mobile/src/components/profiles/skill-form-sheet.tsx	69	Clearing a skill frontmatter description on update is omitted, so the stored value is not cleared
apps/mobile/src/components/profiles/profile-commands-screen.tsx	89	Refetch sync does not bump generation, so in-flight command edits are lost and state diverges from the fields
apps/mobile/src/lib/hooks/use-agent-profile-mutations.ts	97	Optimistic default write ignores owner scoping and personal-first effective-default resolution
apps/web/src/app/(app)/components/PrefetchedOrganizations.tsx	40	Seeding null after a failed SSR context pins ['user'] to signed-out for the 60s staleTime

SUGGESTION

File	Line	Issue
apps/mobile/src/components/profiles/profile-list-model.ts	109	Row subtitle shows commands where web shows MCP servers; mcpServerCount is dropped
tools/i18n/check-catalogs.mjs	221	Expansion-token check misses numeric $1/$2 tokens
apps/mobile/src/components/agents/advanced-config-panel.tsx	154	hasManualConfig counts blank draft rows that are never saved
apps/mobile/src/components/profiles/profile-variables-screen.tsx	105	Variable delete has no in-flight guard, allowing a duplicate delete
apps/mobile/src/components/profiles/repo-bindings-profile-sheet.tsx	57	Profile picker has no empty state

Files Reviewed (231 files)

• apps/mobile/src/components/agents/session-detail-content.tsx - 1 warning
• apps/mobile/src/components/profiles/mcp-form-sheet.tsx - 1 warning
• apps/mobile/src/components/profiles/skill-form-sheet.tsx - 1 warning
• apps/mobile/src/components/profiles/profile-commands-screen.tsx - 1 warning
• apps/mobile/src/lib/hooks/use-agent-profile-mutations.ts - 1 warning
• apps/web/src/app/(app)/components/PrefetchedOrganizations.tsx - 1 warning
• apps/mobile/src/components/profiles/profile-list-model.ts - 1 suggestion
• tools/i18n/check-catalogs.mjs - 1 suggestion
• apps/mobile/src/components/agents/advanced-config-panel.tsx - 1 suggestion
• apps/mobile/src/components/profiles/profile-variables-screen.tsx - 1 suggestion
• apps/mobile/src/components/profiles/repo-bindings-profile-sheet.tsx - 1 suggestion
• All other files in the 231-file PR diff were reviewed; the mobile tRPC mount (packages/trpc/src/agent-profiles-mobile.ts) re-exposes the web router procedures with their existing server-side auth and ensureOrganizationAccess checks, and no memory-leak (uncleaned listeners/subscriptions/timers) patterns were found.

Fix these issues in Kilo Cloud

---

_{Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0}

_{Review guidance: REVIEW.md from base branch main}

[iscekic]

bot: Rejected, no code change (kwf kwf-fix-platform-713b).

Why: (already implemented, verified live: no change needed: Refuted: all 20 flagged added lines are cross-platform expo-router / react-native-safe-area-context imports, and the mobile diff adds no Platform.OS/.ios/.android branch, so there is no platform fork to remove. Finding refuted with evidence. The 20 flagged added lines are imports o

[eshurakov]

Approved after a shallow triage pass. Note: also carries a signed-out web seed fix (SeedUserQuery.tsx).