Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComicVine Finish Line #2779

Merged
merged 8 commits into from
Mar 14, 2024
Merged

ComicVine Finish Line #2779

merged 8 commits into from
Mar 14, 2024

Conversation

majora2007
Copy link
Member

This should be the final addition of code around the new ComicVine library type and the underlying foundational changes to achieve it.

Note: This changes more API code, so komf is likely to need to update to send the new fields and it is expected that Tachiyomi and CDisplayEx are broken.

Added

  • Added: (Scanner) Added a new LowestFolderPath. This is the lowest path that contains all the series files and is used by ScanFolder/Series to avoid extra work.
  • Added: Added support for Locations and Teams, including the filtering for them

Changed

  • Changed: Ignore cover.ext by default on ComicVine parser (develop)
  • Changed: Ensure ComicVine library type defaults to just archive formats (develop)
  • Changed: Adjusted the special parsing for Annuals to account for 'Series Annual \d'
  • Changed: Dependency and security updates
  • Changed: Added a flag to the CBL import to use ComicVine parsing for CBL Import (and set to true as all CBLs to my knowledge are using this new library).
  • Changed: Kavita now handles non-float numbers from CBL Imports (including special cases for comics)

Fixed

  • Fixed: Fixed series cover failing to get the correct cover when just loose leaf and specials (develop)
  • Fixed: Fixed a bad parse when setting sort order and previous chapter is a special type of chapter (19.HU, Alpha, etc) (develop)
  • Fixed: Fixed a rendering bug on CBL validation where the UI reports success but also a warning message appears
  • Fixed: Fixed a bug where Translators couldn't be updated in Edit Series Modal.

API

  • SeriesMetadataDto (for updating series metadata) now has Teams, Locations, Imprints and their lock fields: teamLocked, locationLocked, imprintLocked.

Closes #2714
Closes #2775

… that contains all the series files and is used by ScanFolder to avoid extra work. Hooked this into ScanSeries to avoid extra parsing work when applicable.
…eaf and specials.

Fixed a bad parse when setting sort order and previous chapter is a special type of chapter (19.HU, Alpha, etc).
Added a flag to the CBL import to use ComicVine parsing for CBL Import (and set to true as all CBLs to my knowledge are using this new library).

Started working on a bug where the validation issue UI code is rendered when it shouldn't. Looks like an angular bug.
…but also errors when there wasn't any.

Aligned the UX a bit. Kavita now handles non-float numbers from CBL Imports.

Kavita now supports the new ComicVine library type.
Added Teams and Locations from ComicInfo.

Fixed a bug where Translators couldn't be updated in Edit Series Modal.
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@majora2007 majora2007 merged commit 353d44a into canary Mar 14, 2024
3 checks passed
@majora2007 majora2007 deleted the feature/cbl-and-tweaks branch March 14, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant