Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comic Rework #2714

Closed
30 tasks done
majora2007 opened this issue Feb 12, 2024 · 7 comments
Closed
30 tasks done

Comic Rework #2714

majora2007 opened this issue Feb 12, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@majora2007
Copy link
Member

majora2007 commented Feb 12, 2024

The initial implementation of Comic support was built with limited exposure and limited input from community about Comics. Kavita has grown in size and as such, needs to rework the Comic support to align better with the needs of Comic users.

This is a comprehensive story to tackle such an effort.

Series Grouping

  • Series will now be determined by Series Name + Volume number (year/number) from the first Volume
  • When metadata is not present, Kavita will fallback:
    • First directory if it matches explicitly the format "Series (Year/VolumeNumber)"
    • Check all directories up to root for the above
    • Fallback to Directory name
  • Parallel series (DC Comics/Batman and DC Comics/Marvel) can still be a problem, each with the same run year. (This doesn't seem to be something that can easily be solved. I would opt for users to make a change and Kavita to write new information to the config about this situation)

Misc

  • ComicInfo Format tag with the following values will force the issue to be treated as a special:
  • TBD (Diesel to supply) - currently using existing list
  • Storyline tab will be removed from Series Detail. Issues will be the default tab.
  • Volume tab will be hidden if there is only one Volume
  • Allow for non-numeric, negative, and 0 chapter/issue numbers
  • Covers will generate from issue 1 or greater (if 1 is missing) (issue numbers that aren't natural numbers #2432)
  • Ensure CBL Annuals work (example) (See Comic Rework CBL Enhancements #2775 )
  • Set the Library Formats to just Archive by default
  • Ignore cover.ext files by default in the parser.

Annuals

  • Annuals can be within a series or externally as their own series. The following occurs:
    • If they are their own series, the main series will establish a relationship of Annual to the Annual Series. This will show under Related tab. (this is unfortunately not possible automatically and users will have to perform)
    • If they are within the main series, they will be labelled as "Special". Annuals will be encouraged to be split for the future of this Library and integrations.

ComicInfo Tags

  • Add support to parse and display Imprint tag just like Publisher. This will bring same functionality like Filtering on it.
  • Team
  • Location

Non-Number Issues

  • Issues will have a Sort Order field going forward. This will map with <IssueOrder> tag in ComicInfo. If not present, the issue number will be taken (if it is a number). Otherwise, will fallback to Issue number (<Number>). ComicInfo Enhancement Request
  • Non-numeric issues will be grouped at the start or end (given an arbitrary number).
  • (Stretch) Attempt to parse 18.HU -> 18 or 18.5
  • Admin will be able to edit the non-numberic issue order via ComicInfo or via the UI (This may be pending until the UX refresh)

Tachiyomi

  • This will cause a breakage to Tachiyomi's GetLatestChapter API due to DefaultVolume/Chapter change.

CDisplayEx

  • Need to validate with Henri if this will impact his app. (Validated, Henri will update, need to give a few weeks for testing and support)

Initial Estimate for time to deliver: 200 dev hours

Tests

  • BasicParser
  • ComicVineParser
  • ImageParser
  • PdfParser
  • BookParser (not sure how to implement tests as it relies on actual epub parsing pretty heavily)

Side Stuff noticed during development

  • Annual Series Relationship needs to be put on the wiki/wiki2
  • Need to tweak the Issue names (series detail) - preferring title doesn't look good. Needs to be tweaked until new UX
  • Test converting old Comic library to ComicVine
@majora2007 majora2007 changed the title Comic Rework [WIP] Comic Rework Feb 12, 2024
@majora2007 majora2007 added the enhancement New feature or request label Feb 12, 2024
@majora2007
Copy link
Member Author

Linked discussion:
#2542

@XyberDAWG
Copy link

All of this would vastly improve the overall experience with Western Comics!

@Tomomatoes
Copy link

Tomomatoes commented Feb 15, 2024

Would the changes to annuals allow them to be picked up by imported reading lists?

"(Stretch) Attempt to parse 18.HU -> 18 or 18.5" - This would need to be 18.5 as there is an issue 18 too and 18.HU isn't the only one.
The order is 16, 16.HU, 17, 18, 18.HU, 19, 19.HU, 20, 20,HU. There is also 92.BEY. It would be awesome if you can parse them, if not the <issue order> tag seems like it would still solve the probelm.

@maximo1984
Copy link

Just started using Kavita for comics. I support the above features. I would also like to request an ability to add collections to collections. This would allow a higher level of organization. For example, creating many collections for various genres (super-hero, western, horror, etc), then adding all of those collections to a higher level collection simply titled "Genres"

@maximo1984
Copy link

Can I make some suggestions here? A couple things off top of my head now that I've started using this.

  1. A feature to add single issues to collections, right now, can only add them to reading lists. One application for this would be creating a collection of favorite artists and all their issues drawn. I guess 'reading list' could be used for this, but I think collection is better suited.
  2. Ability to search for creators inside single issues. Right now, it only finds the set/volume/etc. This is problematic for larger comic sets.

@majora2007 majora2007 changed the title [WIP] Comic Rework Comic Rework Mar 7, 2024
@majora2007
Copy link
Member Author

The foundational changes are now in place (and extended testing has begun). This story is now ready to be started.

@majora2007
Copy link
Member Author

majora2007 commented Mar 9, 2024

Testing Issue:

  • Library Type pipe is missing for ComicVine
  • Cover Image isn't preferring Issue 1 when there is a 0 issue
  • Reading list page fails to open when item in ComicVine library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants