-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue numbers that aren't natural numbers #2432
Comments
So this is something that was brought to my attention much after Comics were added and I'm not sure yet how to solve it, since Comics seem to have random rules for issue numbers but yet they need some sort order. Ideally, it would be nice if ComicInfo could support this with a field, but the spec is kinda frozen. There is a feature request here that you can upvote and copy/paste some of the data to. At the moment, I do not have a good solution to fit this into Kavita's model since we use issue numbers as numbers and not strings with some arbitrary order (like ½ wouldn't actually order between 1 and 2 using a string sort, it would have to be custom coded). It is something I am aware of, but again, non-trivial to support and refactor major parts of Kavita for. |
Updated link for discussion around better comic support: |
One additional item in this area is how to handle the cover image for the series. Right now it pulls a 0.5 issue for the cover, but I think in the vast majority of the cases the cover image for the volume should be issue #1. In the example above, the iconic cover for issue #1 from 1964 should be shown instead of a flashback issue from the 90's. |
@flips22 thanks for bringing that to my attention. I took care of it in the preliminary work to accomplish the comic rework. |
The ComicVine library type has been added as of version 0.7.12. That library type should resolve situations like this. If there is any problem using the new library type, please open a new issue. |
Issues with non-standard numbering do not appear in the issues list or they do but are not in the right place.
Steps to reproduce the behavior:
3a. The issues are not present in the list (#-1, #½, # 20.INH); Daredevil (1964) is a good example of -1, Daredevil (1998) for #½, Iron Man (2013) for # 20.INH.
Volume has -1 cover
![image](https://private-user-images.githubusercontent.com/15606205/282878821-d9202624-9454-464d-9853-3a76f6df1dda.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNjA3ODMsIm5iZiI6MTczOTI2MDQ4MywicGF0aCI6Ii8xNTYwNjIwNS8yODI4Nzg4MjEtZDkyMDI2MjQtOTQ1NC00NjRkLTk4NTMtM2E3NmY2ZGYxZGRhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA3NTQ0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY2OTMyZGZhZmQyY2QxNmUyNjQ1ZTgwOTBjNzY1YWNkYjMwNWNkMzMzM2I4OGFlZGM0MTY4NzJhNzI1N2E4NTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qGXu9yKUB2SIm0SGAm_ptmNl_PP-Eq8_mBYyFGcLjgQ)
![image](https://private-user-images.githubusercontent.com/15606205/282878901-2bc66c3d-8925-4a2d-a01d-1925282771e1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNjA3ODMsIm5iZiI6MTczOTI2MDQ4MywicGF0aCI6Ii8xNTYwNjIwNS8yODI4Nzg5MDEtMmJjNjZjM2QtODkyNS00YTJkLWEwMWQtMTkyNTI4Mjc3MWUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA3NTQ0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYzN2MyZWFlZDJlZGJlMmZhMDhhNTljOWRlZjIzZDBlM2Q4NTgwYTQ2N2NjYzc1M2IzNjNjMmI5YTA2MTljYWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ZnmBWtmnYwLXJ4nkm7FJPdq3cQix3NM8YzbUlK5IJlo)
![image](https://private-user-images.githubusercontent.com/15606205/282878978-634952fd-9742-428f-919f-6f83605a4d7a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNjA3ODMsIm5iZiI6MTczOTI2MDQ4MywicGF0aCI6Ii8xNTYwNjIwNS8yODI4Nzg5NzgtNjM0OTUyZmQtOTc0Mi00MjhmLTkxOWYtNmY4MzYwNWE0ZDdhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA3NTQ0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThkMDhlM2JlZTE0NDM2Yjg1Y2QxZWFlYjgwZWVlOTFhOTFkYjM5ZDIyMTYxYTFlOTFhODQ2NmI3MGNiNzMwNWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.xYzuu_WyoH7SeSsysUASt4TcZhlMmahsz1ZeTS5JLMI)
Issue -1 is not in list.
OR
3b. The issues are present (# 1.50) but are sorted according to their issue number rather than published date. Daredevil (2014) is a good example of this where issue 0.1 was published on the same date than issues 5 and 6 but appears before # 1.
A clear and concise description of what you expected to happen.
Versions
Additional context:
Comics scraped with comicvine information sometimes use issue numbers that aren't your standard natural numbers.
The text was updated successfully, but these errors were encountered: