Backports for 1.12.4 #60397
Merged
Backports for 1.12.4 #60397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com> (cherry picked from commit 841148d)
This seems to be an issue at least as far back as 1.10: ```julia $ rm -rf ~/.julia/compiled/*/SuiteSparse/ $ julia +1.10 -q julia> using SuiteSparse [ Info: Precompiling SuiteSparse [4607b0f0-06f3-5cda-b6b1-a6196a1729e9] ``` (cherry picked from commit d6f2a7e)
(cherry picked from commit 5ee0816)
Co-authored-by: dkarrasch <26658441+dkarrasch@users.noreply.github.com> Fix GEMM dispatch for complex-real matmul (#1520)
Member
|
Should the version be 1.12.4, not 1.12.5? |
Member
|
The backport of #59028 to 1.12 was reverted (in #60374) so it should remain on the list. Regarding tidying up labels for PRs that have already been backported.. we're working on some automation to make the process more robust KristofferC/Backporter#14 JuliaLang/Pkg.jl#4562 |
(cherry picked from commit 06ebe6e)
(cherry picked from commit 589a8c6)
Fix #60152, which impacted both lowering implementations. `remove-argument-side-effects` assumed all `kw` arguments from a `parameters` block had already been dumped into the argument list, which is not true in some cases. In addition: - JuliaLowering hit a MethodError in the dumped-`kw` case regardless. There are other issues with `kw` which I'm ignoring in this PR (see #60162) - Delete some ancient history: `&` [used to be a valid argument](a378b75#diff-5d79463faae0f7f19454c7f9888498d9f876082e258ab3efdca36a0ee64b0c87L72) head sometime in 2012 apparently! (cherry picked from commit 2be8847)
(cherry picked from commit 44ecbcf)
Fixed `method_ir_ci` typo in the `abstract_invoke`.
|
Will #60246 be backported to the next v1.12 release? It was already omitted from v1.12.3 and now again, and it is really a fundamental blocker for some packages. Would be really nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
SuiteSparsein pkgimages to precompile #60291_artifact_strin #60383abstract_invoke#60414Need manual backport:
remove-argument-side-effectswith keyword call #60195yin parsingx' = y#60246parse_brackets#60403Contains multiple commits, manual intervention needed:
Non-merged PRs with backport label:
inline_cost_threshold == typemax(Int)#60121Core._apply_iterate#60062