cgutils: fix write barrier of atomic-setonce #59991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to PermutationGroups.jl for dog-fooding our typos! This now matches the runtime implementation in datatype.c (setonce_bits) and ensures that we properly compute the success bit. The test that was intended to check for this is now written to inline that struct and thus actually test for this (undef fields are not eligible for inlining). Fix #59883
vtjnash
added
bug
This was referenced Nov 1, 2025
KristofferC
pushed a commit
that referenced
this pull request
Nov 5, 2025
Thanks to PermutationGroups.jl for dog-fooding our typos! This now matches the runtime implementation in datatype.c (setonce_bits) and ensures that we properly compute the success bit. The test that was intended to check for this is now written to inline that struct and thus actually test for this (undef fields are not eligible for inlining). Fix #59883 (cherry picked from commit c5553c9)
This was referenced Nov 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to PermutationGroups.jl for dog-fooding our typos! This now matches the runtime implementation in datatype.c (setonce_bits) and ensures that we properly compute the success bit. The test that was intended to check for this is now written to inline that struct and thus actually test for this (undef fields are not eligible for inlining).
Fix #59883