-
Notifications
You must be signed in to change notification settings - Fork 5
Add label auditing tools. Minor fixes. #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label auditing tools. Minor fixes. #14
Conversation
|
Would be nice if this could auto detect repo, backport branch etc like the backporter script. This could also be a command to the backporter script. |
|
Why does this need to use the GitHub API to fetch commits? We can just look on the branch locally, or? |
|
I'm not sure I want to add a comment to all the PRs that got backported |
|
My thinking with that was to make it clearer which backport branch a backport actually landed in. Currently there's a lot of crosslink noise when PRs are mentioned but not included in backport PRs. I can imagine it being too many notifications though. |
- Add --audit and --cleanup-pr flags to backporter.jl - Auto-detect repo from git remote (no longer required) - Use local git commands instead of GitHub API for fetching commits - Remove PR comment functionality when removing labels Co-Authored-By: Claude <noreply@anthropic.com>
b11534e to
b0fb7fa
Compare
|
Updated |
I often find myself confused as to whether a PR has been backported yet (and in which backport PR), so I agree that it'd be nice to have a solution to this. One idea I had was to have two backport labels for each release. E.g. for 1.12:
So then when a "Backports for Julia 1.12.x" PR is merged, the backport script would remove the |
|
@KristofferC gave me the commit bit and is happy to give this a try. I think this is a step in the right direction to help track which backport PRs landed in, so I think we should give this a go and then consider more if still needed after a few trials in the wild. |
Uh oh!
There was an error while loading. Please reload this page.