Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quicksort performance tests #562

Closed
ViralBShah opened this issue Mar 11, 2012 · 8 comments
Closed

quicksort performance tests #562

ViralBShah opened this issue Mar 11, 2012 · 8 comments
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request

Comments

@ViralBShah
Copy link
Member

Currently, the quicksort performance tests across various languages are written in a variety of different ways. It would be best to implement the same algorithm, without randomness across all languages.

@StefanKarpinski
Copy link
Member

Remaining todos here:

  • Someone needs to go through all the different versions and make sure they're doing the same thing.
  • Use a common simple pseudorandom number generator so that all languages are sorting the same array.

JeffBezanson added a commit that referenced this issue Mar 17, 2012
difference is small
@ViralBShah
Copy link
Member Author

Only the javascript version remains now. We should update our performance table on the website when the js version is done.

@ViralBShah
Copy link
Member Author

Also, we can simply sort [n:-1:1] and avoid writing a pseudorandom number generator.

@StefanKarpinski
Copy link
Member

That's a lousy test of qsort because it only tests one swapping pattern over and over instead of mixing it up.

@ViralBShah
Copy link
Member Author

I think it is good enough for the purpose. Of course, an RNG is only 5 lines or so, but you have to write it in every language.

-viral

On 17-Mar-2012, at 11:57 PM, Stefan Karpinski wrote:

That's a lousy test of qsort because it only tests one swapping pattern over and over instead of mixing it up.


Reply to this email directly or view it on GitHub:
#562 (comment)

@Bluebugs
Copy link

Or just put the same huge randonmly filled array in each language. That would make it almost just a copy past.

@ViralBShah
Copy link
Member Author

@StefanKarpinski
Copy link
Member

This seems to be in good enough shape now.

ViralBShah pushed a commit that referenced this issue Nov 12, 2024
Stdlib: SparseArrays
URL: https://github.com/JuliaSparse/SparseArrays.jl.git
Stdlib branch: main
Julia branch: master
Old commit: 0dd8d45
New commit: 14333ea
Julia version: 1.12.0-DEV
SparseArrays version: 1.12.0
Bump invoked by: @ViralBShah
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaSparse/SparseArrays.jl@0dd8d45...14333ea

```
$ git log --oneline 0dd8d45..14333ea
14333ea Break recursion (#579)
07cf4a6 Update ci.yml (#578)
33491e0 added diagonal-sparse multiplication (#564)
8f02b7f doc: move solvers doc to `src\solvers.md` (#576)
485fd4b Inline sparse-times-dense in-place multiplication (#567)
f10d4da added specialized method for 3-argument dot with diagonal matrix (#565)
70c06b1 Diagonal-sandwiched triple product for SparseMatrixCSC (#562)
313a04f Change default QR tolerance to match SPQR (#557)
81d49e9 Update ci.yml (#558)
```

Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Development

No branches or pull requests

3 participants