Use bzbarsky's JS quicksort; make JSLint mostly happy about perf.js #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction to direct implementation. Implementation of quicksort provided by Boris Zbarsky. https://groups.google.com/d/msg/mozilla.dev.tech.js-engine/Ct6JsfJEjdI/AetfGW6h07gJ
…g accidental global variables.
|
Awesome. I guess it's time to re-run all the benchmarks. |
StefanKarpinski
added a commit
that referenced
this pull request
Mar 25, 2012
Use bzbarsky's JS quicksort; make JSLint mostly happy about perf.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've integrated the JS quicksort provided by bzbarsky, then painstakingly moved
vars around until JSLint stopped complaining about them. That should fix all the global-ness. I also made a number of other changes suggested by JSLint.I can't get the typed arrays to work running perf.js from node.js (the only NPM package I found doesn't support Float64Array), so someone else might want to test this first.
Part of #562.