Skip to content

Conversation

@bedeho
Copy link
Member

@bedeho bedeho commented Feb 17, 2020

Long-running PR for v2.0 of the proposal system

  • Basic structure
  • Slashing of proposals
  • Finalized execution model
  • First proposals
    • Runtime upgrade
    • Spending
    • Signaling

shamil-gadelshin and others added 30 commits February 11, 2020 16:33
- add iteration 2 codex and engine modules
- delete codex/Cargo.lock
- delete engine/Cargo.lock
- update gitignore
- change approval quorum
- introduce approval threshold
- add tests
- add proposal parameter
- add proposal status ‘PendingExecution’
- change proposal status and execution algorithms
- add tests
- move acquiring proposal_id inside the method
- introduce ProposalId type
- change BTreeSet to the linked_map
- change VoteExistsByProposalByAccount to proposal_id first key
- clear cache on proposal finalization
- rename and refactor tally() method in functional style
- introduce internal type FinalizedProposalData
- add joystream stake & substrate balances dependency
- modify mocks
- add stake to the ProposalParameters
Migrating from TallyResults and vote calculation in the end of block to vote calculation on the vote() extrinsic call.
Migrating out from TallyResults
- refactor map-filter-map pattern to the filter_map
- add comments
- add next text field and tests
- introduce Error enum
bedeho and others added 27 commits April 6, 2020 11:11
Proposals. Version 2. Merge runtime latest commits from development branch.
…iteration7

# Conflicts:
#	Cargo.lock
#	runtime-modules/proposals/codex/Cargo.toml
#	runtime-modules/proposals/engine/src/tests/mock/balance_manager.rs
…_with_dev_commits

Propovals. Version 2. Iteration7 (pre-merged with development)
- add ‘create_evict_storage_provider_proposal’ extrinsic to the codex module
- add tests
- add ‘create_set_validator_count_proposal’ extrinsic to the codex module
- add tests
- add ‘create_set_storage_role_parameters_proposal’ extrinsic
- add tests
- fix reset_proposal() in the engine module: clean VoteExistsByProposalByVoter double map
- add tests
- change upgrade runtime proposal in the codex module: add allowed proposers whitelist
- add tests
- set proposal limits and introduce errors
- update spending proposal parameters
- introduce total issuance token percentage
- migrate engine module quorum & threshold calculations from float division to Substrate Perbill type
- add tests
- remove proposal from the codex
- remove tests
- remove parameters and proposal details
@bedeho bedeho marked this pull request as ready for review April 20, 2020 12:21
@bedeho bedeho merged commit 480391c into development Apr 21, 2020
@mnaamani mnaamani deleted the proposals_v2 branch July 3, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants