-
Notifications
You must be signed in to change notification settings - Fork 115
2.0 Proposals system #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
2.0 Proposals system #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add iteration 2 codex and engine modules
- delete codex/Cargo.lock - delete engine/Cargo.lock - update gitignore
- change approval quorum - introduce approval threshold - add tests
- add proposal parameter - add proposal status ‘PendingExecution’ - change proposal status and execution algorithms - add tests
- move acquiring proposal_id inside the method
- introduce ProposalId type - change BTreeSet to the linked_map
- change VoteExistsByProposalByAccount to proposal_id first key - clear cache on proposal finalization
- rename and refactor tally() method in functional style - introduce internal type FinalizedProposalData
- add joystream stake & substrate balances dependency - modify mocks - add stake to the ProposalParameters
Migrating from TallyResults and vote calculation in the end of block to vote calculation on the vote() extrinsic call.
Migrating out from TallyResults
- refactor map-filter-map pattern to the filter_map - add comments
- add next text field and tests - introduce Error enum
…_review Proposals v2 iteration2
Proposals. Version 2. Merge runtime latest commits from development branch.
…iteration7 # Conflicts: # Cargo.lock # runtime-modules/proposals/codex/Cargo.toml # runtime-modules/proposals/engine/src/tests/mock/balance_manager.rs
…_with_dev_commits Propovals. Version 2. Iteration7 (pre-merged with development)
- add ‘create_evict_storage_provider_proposal’ extrinsic to the codex module - add tests
- add ‘create_set_validator_count_proposal’ extrinsic to the codex module - add tests
- add ‘create_set_storage_role_parameters_proposal’ extrinsic - add tests
- fix reset_proposal() in the engine module: clean VoteExistsByProposalByVoter double map - add tests
- change upgrade runtime proposal in the codex module: add allowed proposers whitelist - add tests
- set proposal limits and introduce errors - update spending proposal parameters - introduce total issuance token percentage
- migrate engine module quorum & threshold calculations from float division to Substrate Perbill type - add tests
- remove proposal from the codex - remove tests - remove parameters and proposal details
Proposals.Version 2.Iteration 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long-running PR for v2.0 of the proposal system