Skip to content

Conversation

@shamil-gadelshin
Copy link
Contributor

Proposals

  • Spending proposal
  • Set CM Mint Capacity proposal
  • Set Lead proposal
  • Set WG Mint Capacity proposal
  • Set Council Parameters proposal

Integrations

  • stake module fixes
  • latest runtime monorepo upgrade with full-node
  • module runtime integration tests

Miscellaneous

  • cancellation, rejection fees tests
  • council reelection hooks
  • missing tests for decl_error! macro errors
  • numerous refactorings and improved comments
  • removing proposals v1 from node config

Comment: this PR contains numerous merges from the development to support runtime latest features. Old PR

- use slash_immediate() instead of initiate_slashing()
# Conflicts:
#	runtime-modules/proposals/engine/src/types/stakes.rs
- remove obsolete TODOs
- add printing messages about broken invariants refund_proposal_stake()
- add CouncilElected hook for the proposals
- remove unused error.rs
- add some comments
- add reset_active_proposals() and tests
- add runtime integration test proposal_reset_succeeds()
# Conflicts:
#	runtime-modules/governance/src/lib.rs
- add ‘set_election_parameters’ extrinsic
- add tests
- add check for correct proposal type for other extrinsics
# Conflicts:
#	node/src/chain_spec.rs
#	runtime-modules/governance/src/proposals.rs
#	runtime/src/lib.rs
- add create_set_content_working_group_mint_capacity_proposal() extrinsic to the codex module
- add tests
- refactor codex module tests
- add ‘spending proposal’ extrinsic to the codex module
- add tests
- add ‘create_set_lead_proposal()’ extrinsic in the codex module
- add tests
…iteration7

# Conflicts:
#	Cargo.lock
#	runtime-modules/proposals/codex/Cargo.toml
#	runtime-modules/proposals/engine/src/tests/mock/balance_manager.rs
@shamil-gadelshin shamil-gadelshin requested a review from bedeho April 6, 2020 09:46
@bedeho bedeho merged commit 6952350 into Joystream:proposals_v2 Apr 19, 2020
bedeho pushed a commit that referenced this pull request May 29, 2020
Default TxButton to live mode, unless a mock transport is used
@shamil-gadelshin shamil-gadelshin deleted the propovals_v2_iteration7_with_dev_commits branch June 25, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants