Skip to content

Proposals.Version 2.Iteration 8 #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bedeho merged 23 commits into from
Apr 20, 2020
Merged

Proposals.Version 2.Iteration 8 #279

bedeho merged 23 commits into from
Apr 20, 2020

Conversation

@shamil-gadelshin
Copy link
Contributor

@shamil-gadelshin shamil-gadelshin commented Apr 13, 2020 •
edited
Loading

Features

  • veto for the approved pending execution proposal
  • reset a proposal after council reelection
  • change upgrade runtime proposal: introduce fixed allowed member list
  • add proposals: 'evict storage provider', 'set validator count', 'set storage role parameters'
  • set actual proposal type parameters
  • set actual proposal runtime parameters
  • change 'veto_proposal' to affect approved proposal during the grace period
  • fix clippy linter issues
  • migrate proposal votes calculations to Perbill
  • remove allowed member_id list for runtime upgrade proposal
  • improve comments

@shamil-gadelshin shamil-gadelshin requested a review from bedeho April 13, 2020 15:37
@shamil-gadelshin shamil-gadelshin mentioned this pull request Apr 13, 2020
Closed
@shamil-gadelshin shamil-gadelshin changed the base branch from proposals_v2 to development April 20, 2020 06:48
@shamil-gadelshin shamil-gadelshin changed the base branch from development to proposals_v2 April 20, 2020 06:48
@shamil-gadelshin shamil-gadelshin marked this pull request as ready for review April 20, 2020 07:02
@shamil-gadelshin
Add codex ProposalDetails for the frontend
34b0e7c
@shamil-gadelshin
Add ‘create_evict_storage_provider_proposal’ extrinsic
51cde50 
- add ‘create_evict_storage_provider_proposal’ extrinsic to the codex module
- add tests
@shamil-gadelshin
Add ‘create_set_validator_count_proposal’ extrinsic
b994ee7 
- add ‘create_set_validator_count_proposal’ extrinsic to the codex module
- add tests
@shamil-gadelshin
Add ‘create_set_storage_role_parameters_proposal’ extrinsic
e77768a 
- add ‘create_set_storage_role_parameters_proposal’ extrinsic
- add tests
@shamil-gadelshin
Fix reset_proposal() in the engine module
6c01c09 
- fix reset_proposal() in the engine module: clean VoteExistsByProposalByVoter double map
- add tests
@shamil-gadelshin
Change upgrade runtime proposal
020f3c7 
- change upgrade runtime proposal in the codex module: add allowed proposers whitelist
- add tests
@shamil-gadelshin
Add some comments to proposal modules
ab54a82
@shamil-gadelshin
Set min validator count for the proposals
c27a869
@shamil-gadelshin
Add ensure_storage_role_parameters_valid() to the codex
aa793af
@shamil-gadelshin
Add ensure_council_election_parameters_valid() to the codex
96720b4
@shamil-gadelshin
Change min_validator_count() limit in the codex
e8dbdcb
@shamil-gadelshin
Add veto for the pending execution proposal.
b679257
@shamil-gadelshin
Set general proposal parameters.
f55dcf6
@shamil-gadelshin
Update proposals runtime parameters
1884aa0
@shamil-gadelshin
Set proposal parameters
dda832e 
- set proposal limits and introduce errors
- update spending proposal parameters
- introduce total issuance token percentage
@shamil-gadelshin
Fix clippy comments
61a8127
@shamil-gadelshin
Add comments
a9bbf47
@shamil-gadelshin
Update comments
74e1fe2
@shamil-gadelshin
Add missing tests
00872d6
@shamil-gadelshin
Add tests for proposal status resolution
1683ac4
@shamil-gadelshin
Migrate proposal votes calculations to Perbill
cb80ece 
- migrate engine module quorum & threshold calculations from float division to Substrate Perbill type
- add tests
@shamil-gadelshin
Remove allowd member_id list for runtime upgrade proposal
ad3705b
@shamil-gadelshin shamil-gadelshin force-pushed the proposals_v2_iteration8 branch from 47b487c to ad3705b Compare April 20, 2020 07:25
@shamil-gadelshin shamil-gadelshin changed the base branch from proposals_v2 to development April 20, 2020 07:25
@shamil-gadelshin shamil-gadelshin changed the base branch from development to proposals_v2 April 20, 2020 07:25
bedeho
bedeho requested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@bedeho bedeho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We decided to not have proposal for setting council capacity, for reasons that are too nuanced to unpack here, so just drop that one.

  • Nice work on the docs!

@shamil-gadelshin
Remove ‘set council mint capacity’ proposal
c2c9cb3 
- remove proposal from the codex
- remove tests
- remove parameters and proposal details
@bedeho bedeho merged commit d193854 into Joystream:proposals_v2 Apr 20, 2020
@shamil-gadelshin shamil-gadelshin deleted the proposals_v2_iteration8 branch June 25, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bedeho bedeho bedeho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shamil-gadelshin @bedeho