CMake samples #84

JayFoxRox · 2021-04-11T14:52:38Z

Based on #74

Adds the samples, but, more importantly, shows what kind of problems have to be solved in nxdk before many large libs can be ported.

The changes from this should be polished and upstreamed, but I likely won't be doing that.

JayFoxRox · 2021-04-11T15:42:42Z

samples/cmake/newton-dynamics/README.md

+mkdir build
+cd build
+${NXDK_DIR}/usr/bin/nxdk-cmake ..
+${NXDK_DIR}/usr/bin/nxdk-cmake ..


Why is it necessary to run cmake twice tho?

I did not check if this also happens when building for linux (with these flags)

JayFoxRox · 2021-04-11T15:43:07Z

samples/cmake/newton-dynamics/README.md

+git clone https://github.com/MADEAPPS/newton-dynamics.git --branch v3.14c --depth=1
+mkdir build
+cd build
+${NXDK_DIR}/usr/bin/nxdk-cmake ..


This will also complain a bunch about libs being forced from SHARED to STATIC

JayFoxRox · 2021-04-11T15:44:25Z

samples/cmake/newton-dynamics/CMakeLists.txt

+  -DEM_DENORMAL=1
+  -DEM_ZERODIVIDE=1
+  -D_clearfp\(...\)=0
+  -D_controlfp\(...\)=0


Up until this point is #76

JayFoxRox · 2021-04-11T15:44:41Z

samples/cmake/newton-dynamics/CMakeLists.txt

+  -D_clearfp\(...\)=0
+  -D_controlfp\(...\)=0
+  -D_finite\(...\)=0
+  -D_isnan\(...\)=0


Not sure if this is part of #76 yet, or whereelse it might be handled

Made upstream issue nxdk 452, so hopefully someone picks it up

JayFoxRox · 2021-04-11T16:04:55Z

samples/cmake/glm/main.cpp

+
+  glm::vec3 v = glm::vec3(0.0f, 1.0f, 2.0f);
+
+  debugPrint("Hello World! %d", int(1000.0 * glm::length(v)));


Should be (int) or ideally static_cast<int>(...)

JayFoxRox · 2021-04-11T16:05:17Z

samples/cmake/glm/main.cpp

+
+  debugPrint("Hello World! %d", int(1000.0 * glm::length(v)));
+  while(1);
+  return 0;


Bad practice to have this after an endless loop (other instance, too)

JayFoxRox · 2021-04-11T16:07:09Z

samples/cmake/enet/CMakeLists.txt

+    "${NXDK_DIR}/lib/net/nforceif/src/sys_arch.c"
+  )
+  target_link_libraries(net lwipcore pktdrv)
+endif()


# Combine lwip and Xbox driver into libnet

This should be part of nxdk, not of this sample.
Reported as upstream issue 454.

@Teufelchen1: This is probably a good task for you
Maybe a challenge for @kosmas12 if @Teufelchen1 doesn't want to do this.

(nxdk issue 454: "Network stack should be a static library")

JayFoxRox · 2021-04-11T16:08:21Z

samples/cmake/ozz-animation/README.md

+git clone https://github.com/guillaumeblanc/ozz-animation.git --branch 0.13.0 --depth=1
+mkdir build
+cd build
+${NXDK_DIR}/usr/bin/nxdk-cmake ..


I found an older comment saying:

ozz needs CMake to run twice; also the SDL renderer was not tested on Xbox, because it hangs during startup (fails to load skeleton / animation)

Compare https://github.com/JayFoxRox/nxdk/pull/84/files#r611207045

JayFoxRox · 2021-04-11T16:56:46Z

samples/cmake/Makefile

@@ -0,0 +1,3 @@
+# Dummy file, so the CI doesn't trip
+# Ideally this should be building the CMake projects on CI


JayFoxRox · 2021-04-11T16:57:45Z

samples/cmake/enet/CMakeLists.txt

@@ -0,0 +1,50 @@
+if(NXDK)
+  # Hack for winsock2.h and mmsystem.h
+  include_directories(SYSTEM "${NXDK_DIR}/lib/winapi/ws2_32;${NXDK_DIR}/lib/winapi/winmm")


These should be part of default includes; I believe this is an upstream nxdk bug which will have to be integrated in #82

(speaking about winmm; obviously ws2_32 is a separate issue as it's part of this PR)

JayFoxRox · 2021-04-11T17:00:15Z

lib/winapi/Makefile

@@ -1,4 +1,5 @@
 include $(NXDK_DIR)/lib/winapi/winmm/Makefile
+include $(NXDK_DIR)/lib/winapi/ws2_32/Makefile


ws2_32 should be split from this PR, cleaned, polished, and upstreamed.

Maybe @dracc or @Teufelchen1 (also @thrimbor or @Ryzee119, but those got too many tasks already)

JayFoxRox · 2021-04-11T17:02:17Z

samples/cmake/enet/CMakeLists.txt

+if(NXDK)
+  # Make enet depend on Xbox network
+  set_target_properties(enet
+                        PROPERTIES LINK_LIBRARIES "${NXDK_DIR}/lib/ws2_32.lib;${NXDK_DIR}/lib/winmm.lib;net")


Why aren't ws2_32 and winmm already deps of enet or the net library?
Should be fixed (upstream potentially?)

Part of lsalzman/enet#147 and lsalzman/enet#184

JayFoxRox · 2021-04-11T17:03:19Z

samples/cmake/enet/main.c

+
+  // We should never reach this
+  return 1;
+}


Yikes, not sure why I had this file? This probably needs a menu or something

JayFoxRox · 2021-04-11T17:03:54Z

samples/cmake/newton-dynamics/main.cpp

+_PDCLIB_PUBLIC double atof( const char * nptr ) {
+  return 0.0f;
+}
+}


Clearly this is a hack - must be fixed upstream in nxdk / nxdk-pdclib or somewhere.

JayFoxRox · 2021-04-11T17:05:10Z

samples/cmake/ozz-animation/CMakeLists.txt

+if(NXDK)
+  # Hack for memory.h
+  file(TOUCH ${CMAKE_CURRENT_BINARY_DIR}/memory.h)
+  include_directories(SYSTEM "${CMAKE_CURRENT_BINARY_DIR}/")


I'm not sure what <memory.h> is, but an empty file is enough.

Fix upstream in ozz-animation by removing the inclusion if it's really not necessary.
Fix in nxdk by adding a dummy file (not sure where? winapi?) if it's actually used in ozz-animation.

JayFoxRox · 2021-04-11T17:05:54Z

samples/cmake/ozz-animation/CMakeLists.txt

+add_subdirectory(ozz-animation EXCLUDE_FROM_ALL)
+
+target_compile_options(ozz_base PUBLIC
+  -Dcout=clog


nxdk-libcxx issue 5: std::cout does not exist, but std::clog and std::cerr exist

JayFoxRox · 2021-04-11T17:06:08Z

samples/cmake/ozz-animation/CMakeLists.txt

+#  COMMAND ${CMAKE_COMMAND} -E make_directory media
+#  COMMAND ${CMAKE_COMMAND} -E copy "${ozz_media_directory}/bin/alain_skeleton.ozz" "./media/skeleton.ozz"
+#  COMMAND ${CMAKE_COMMAND} -E copy "${ozz_media_directory}/bin/alain_crossarms.ozz" "./media/animation.ozz"
+#  VERBATIM)


JayFoxRox · 2021-04-11T17:06:20Z

samples/cmake/ozz-animation/CMakeLists.txt

+add_executable(default
+  main.cpp
+#  "${CMAKE_CURRENT_BINARY_DIR}/media/skeleton.ozz"
+#  "${CMAKE_CURRENT_BINARY_DIR}/media/animation.ozz"


JayFoxRox · 2021-04-11T17:07:45Z

samples/cmake/ozz-animation/main.cpp

+    }
+
+  }
+}


When I updated ozz earlier I had to fix a bunch of stuff in this sample. I wasn't sure where the ozz related code originated (I remember writing the SDL2 line-renderer stuff myself though), so I just patched some spots.

The ozz related code should be taken from a sample so it matches upstream again.

I know that this sample worked in the past.
However, I did not try running this sample since updating ozz.

JayFoxRox · 2022-06-01T13:10:25Z

samples/cmake/enet/CMakeLists.txt

+# Add enet and fix a bug in enet where include folder is not known to itself
+add_subdirectory(enet)
+set_target_properties(enet
+                      PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${CMAKE_SOURCE_DIR}/enet/include/")


I believe this is broken due to https://github.com/lsalzman/enet/blame/master/CMakeLists.txt#L58 using the wrong variable?

However, it should not be setting include directories for all targets anyway

JayFoxRox force-pushed the cmake-samples branch from 38f9091 to 5a51129 Compare April 11, 2021 15:05

JayFoxRox force-pushed the cmake branch from 0d80b23 to dd960e1 Compare April 11, 2021 15:09

JayFoxRox force-pushed the cmake-samples branch from 5a51129 to f12eb9a Compare April 11, 2021 15:09

JayFoxRox force-pushed the cmake branch from dd960e1 to 5bfd1d3 Compare April 11, 2021 15:26

JayFoxRox force-pushed the cmake-samples branch 2 times, most recently from 4f4388a to 77fe192 Compare April 11, 2021 15:42

JayFoxRox commented Apr 11, 2021

View reviewed changes

JayFoxRox force-pushed the cmake-samples branch from 77fe192 to be38cc6 Compare April 11, 2021 15:43

JayFoxRox commented Apr 11, 2021

View reviewed changes

JayFoxRox force-pushed the cmake-samples branch 2 times, most recently from 871b7c8 to f378d5f Compare April 11, 2021 16:50

JayFoxRox commented Apr 11, 2021

View reviewed changes

JayFoxRox mentioned this pull request Apr 11, 2021

Winsock implementation XboxDev/nxdk#453

Open

JayFoxRox force-pushed the cmake branch from 5bfd1d3 to f16d102 Compare April 11, 2021 21:59

JayFoxRox added 2 commits April 12, 2021 00:00

winapi: Add winsock implementation

dd5466b

samples: Add CMake samples

f6a5a98

JayFoxRox force-pushed the cmake-samples branch from f378d5f to f6a5a98 Compare April 11, 2021 22:00

This was referenced Apr 11, 2021

Add nxdk specific wrappers to expose a common toolchain interface #82

Open

Improve network performance XboxDev/nxdk#460

Closed

JayFoxRox commented Jun 1, 2022

View reviewed changes

JayFoxRox mentioned this pull request Mar 7, 2023

SDL_mixer port XboxDev/nxdk#289

Open

JayFoxRox mentioned this pull request Jun 9, 2023

Using CMake or some other build system generator XboxDev/nxdk#407

Closed

This was referenced Oct 19, 2024

feat(winapi): add winsock2 XboxDev/nxdk#680

Closed

build(deps): add moonlight-common-c LizardByte/Moonlight-XboxOG#3

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CMake samples #84

CMake samples #84

JayFoxRox commented Apr 11, 2021

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021 •

edited

Loading

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021 •

edited

Loading

JayFoxRox Apr 11, 2021 •

edited

Loading

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021 •

edited

Loading

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021

JayFoxRox Jun 1, 2022

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021 •

edited

Loading

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021

JayFoxRox Apr 11, 2021 •

edited

Loading

JayFoxRox Jun 1, 2022


		glm::vec3 v = glm::vec3(0.0f, 1.0f, 2.0f);

		debugPrint("Hello World! %d", int(1000.0 * glm::length(v)));

		@@ -0,0 +1,3 @@
		# Dummy file, so the CI doesn't trip
		# Ideally this should be building the CMake projects on CI

		@@ -1,4 +1,5 @@
		include $(NXDK_DIR)/lib/winapi/winmm/Makefile
		include $(NXDK_DIR)/lib/winapi/ws2_32/Makefile

+                  }
+                }
+              }

CMake samples #84

Are you sure you want to change the base?

CMake samples #84

Conversation

JayFoxRox commented Apr 11, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JayFoxRox Apr 11, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JayFoxRox Apr 11, 2021 • edited Loading

Choose a reason for hiding this comment

JayFoxRox Apr 11, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JayFoxRox Apr 11, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JayFoxRox Apr 11, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JayFoxRox Apr 11, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JayFoxRox Apr 11, 2021 •

edited

Loading

JayFoxRox Apr 11, 2021 •

edited

Loading

JayFoxRox Apr 11, 2021 •

edited

Loading

JayFoxRox Apr 11, 2021 •

edited

Loading

JayFoxRox Apr 11, 2021 •

edited

Loading

JayFoxRox Apr 11, 2021 •

edited

Loading