libc: Add some Microsoft FPU control and status extensions #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
commented
May 4, 2020
|
|
||
| unsigned int _control87(unsigned int new, unsigned int mask); | ||
| unsigned int _controlfp(unsigned int new, unsigned int mask); | ||
| int __control87_2(unsigned int new, unsigned int mask, unsigned int* x86_cw, unsigned int* sse2_cw); |
There was a problem hiding this comment.
The use of new trips my syntax highlighter. I worry that C++ might be problematic.
JayFoxRox
commented
May 4, 2020
|
|
||
| unsigned int _status87(void); | ||
| unsigned int _statusfp(void); | ||
| void _statusfp2(unsigned int *px86, unsigned int *pSSE2); |
There was a problem hiding this comment.
The argument style of this differs from the other functions (but I believe all of this came from MSDN).
JayFoxRox
commented
May 4, 2020
| if (flags & _EM_UNDERFLOW) fpword |= 0x10; | ||
| if (flags & _EM_INEXACT) fpword |= 0x20; | ||
|
|
||
| switch (flags & _MCW_RC) { |
There was a problem hiding this comment.
These deserve some comment
JayFoxRox
commented
May 4, 2020
| #define _SW_OVERFLOW 0x00000004 | ||
| #define _SW_ZERODIVIDE 0x00000008 | ||
| #define _SW_INVALID 0x00000010 | ||
| #define _SW_DENORMAL 0x00080000 |
There was a problem hiding this comment.
Wine uses these, but they don't seem to be from MS. But I was unable to find a MS FLOAT.H to verify.
We could also use _EM_*, but I felt it was ugly to assume that cw and sw used the same layout (even though they mostly do).
There was a problem hiding this comment.
CC @thrimbor, master of Microsoft / mingw header files.
This was referenced Apr 11, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on nxdk-pdclib PR 29.
Code was stolen from mingw, wine and some other projects. I don't think this is algorithmic enough to qualify for copyright. I also made a number of changes to formatting and removed SSE2 portions to make the code more concise.
The code was never tested.