Skip to content

CMake improvements #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

CMake improvements #147

wants to merge 10 commits into from

Conversation

moien007
Copy link

@moien007 moien007 commented Dec 29, 2020

This is PR #137 (which I messed up, my bad) plus new changes.

Changes are:

  • Upgrading from CMake 2.6 to 3.4.3
  • Linking against ws2_32 and winmm if compiler is MSVC
  • Conditionally defining ENET_DLL macro
  • Exporting all symbols for Win32 so that a .def file or __declspec(dllexport) is not required

@Croydon
Copy link
Contributor

Croydon commented Aug 25, 2021

@moien007 Not sure if you are still motivated since you did not get an official response, but could you perhaps rebase this? Thanks!

@moien007
Copy link
Author

@moien007 Not sure if you are still motivated since you did not get an official response, but could you perhaps rebase this? Thanks!

Solved the merge conflict; is that what you meant?

@Croydon
Copy link
Contributor

Croydon commented Aug 26, 2021

Yes, thanks.

@lsalzman Could you perhaps have a look at this patch? It isn't big so it shouldn't take long to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants