-
Notifications
You must be signed in to change notification settings - Fork 692
CMake improvements #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake improvements #147
Conversation
[CMAKE] Using standard BUILD_SHARED_LIBS. Co-authored-by: Michael "Croydon" Keck <[email protected]>
Co-authored-by: Michael "Croydon" Keck <[email protected]>
ffec9dc
to
5697255
Compare
@moien007 Not sure if you are still motivated since you did not get an official response, but could you perhaps rebase this? Thanks! |
Solved the merge conflict; is that what you meant? |
Yes, thanks. @lsalzman Could you perhaps have a look at this patch? It isn't big so it shouldn't take long to review |
This is PR #137 (which I messed up, my bad) plus new changes.
Changes are:
ws2_32
andwinmm
if compiler is MSVCENET_DLL
macro.def
file or__declspec(dllexport)
is not required