Added a setting to show File annotations' tab only when the PDF actually contains highlights or comments #13279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… show the file annotation tab when annotations are not present in the entry files.
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| this.shouldShowLatexCitationsTab.set(shouldShowLatexCitationsTab); | ||
| } | ||
|
|
||
| public boolean shouldShowFileAnnotationsTab() { |
There was a problem hiding this comment.
The method should return an Optional instead of a primitive boolean to avoid returning null and adhere to modern Java practices.
Contributor
Author
There was a problem hiding this comment.
is that really necessary?I don't think it could ever return a null value
Member
There was a problem hiding this comment.
Take the comments with a grain of salt. In this case the bot is wrong
Comment on lines
+29
to
+30
| public FileAnnotationTab(StateManager stateManager, | ||
| GuiPreferences preferences) { |
There was a problem hiding this comment.
The constructor should not allow null values for 'stateManager' and 'preferences'. Consider using JSpecify @nonnull annotations to enforce non-null parameters.
Contributor
Author
There was a problem hiding this comment.
is that really necessary?
Siedlerchr
approved these changes
Jun 11, 2025
koppor
requested changes
Jun 13, 2025
jabgui/src/main/resources/org/jabref/gui/preferences/entryeditor/EntryEditorTab.fxml
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/entryeditor/fileannotationtab/FileAnnotationTab.java
Show resolved
Hide resolved
Siedlerchr
added a commit
to FlyJoanne/jabref
that referenced
this pull request
Jun 15, 2025
* upstream/main: New Crowdin updates (JabRef#13330) Add arm 64 linux runner (JabRef#13258) Rename strings and variables in New Entry (JabRef#13312) Let consistency checker yield a return code (JabRef#13329) Update LETTER fragment to resolve Windows parsing issue (JabRef#13327) Add support for "dev: no-bot-comments" Update dependency org.hibernate.validator:hibernate-validator to v9.0.1.Final (JabRef#13322) Endnote XML Exporter: Move factory initialization to constructor (JabRef#13321) Refine assignment reminder (JabRef#13315) Add welcome message to first time contributors (JabRef#13314) New Crowdin updates (JabRef#13311) Added a setting to show File annotations' tab only when the PDF actually contains highlights or comments (JabRef#13279) Update dependency org.postgresql:postgresql to v42.7.7 (JabRef#13306) Refine PULL_REQUEST_TEMPLATE.md (JabRef#13304) Move module tweaking of merged module to launcher (JabRef#13303) Speed up gradle update (JabRef#13300) testImplementation is enough (JabRef#13299)
ZodGaz
added a commit
to ZodGaz/jabref
that referenced
this pull request
Jun 16, 2025
…rewrote shouldShow in FileAnnotationTab as requested in JabRef#13279
4 tasks
Siedlerchr
added a commit
to MiguelCBar/jabref
that referenced
this pull request
Jun 18, 2025
* upstream/main: (47 commits) Adapt some fetcher tests (JabRef#13370) change template issue number (JabRef#13367) Refine error message in URLUtil::create (JabRef#13337) fix deletion again (JabRef#13369) Only prevent failure in publishing from stopping the workflow (JabRef#13368) Refactor "enableFileAnnotationsTab" to "smartFileAnnotationsTab" and rewrote shouldShow in FileAnnotationTab as requested in JabRef#13279 (JabRef#13338) fix workflow (JabRef#13366) Fixamd64linux (JabRef#13365) Only delete for arm64 (JabRef#13364) New Crowdin updates (JabRef#13363) Bump org.junit.jupiter:junit-jupiter-api in /versions (JabRef#13362) Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (JabRef#13359) Bump com.github.javaparser:javaparser-symbol-solver-core in /versions (JabRef#13361) Bump org.junit.platform:junit-platform-launcher in /versions (JabRef#13360) Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 in /versions (JabRef#13358) Gradle build updates (JabRef#13319) Add "Disable GitHub actions" (JabRef#13356) Make jabref host executable on mac and on linux and fix import command line argument (JabRef#13355) Delete .github/workflows/merge-upstream.yml (JabRef#13357) chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.25.0 (JabRef#13353) ...
Siedlerchr
added a commit
to ganesh-vk/jabref
that referenced
this pull request
Jun 18, 2025
* upstream/main: (54 commits) Move publishing to maven central to a separate workflow (JabRef#13372) Add more guards to workflows not running on forked JabRef repos Copy real HTML from entry preview (JabRef#13339) Adapt some fetcher tests (JabRef#13370) change template issue number (JabRef#13367) Refine error message in URLUtil::create (JabRef#13337) fix deletion again (JabRef#13369) Only prevent failure in publishing from stopping the workflow (JabRef#13368) Refactor "enableFileAnnotationsTab" to "smartFileAnnotationsTab" and rewrote shouldShow in FileAnnotationTab as requested in JabRef#13279 (JabRef#13338) fix workflow (JabRef#13366) Fixamd64linux (JabRef#13365) Only delete for arm64 (JabRef#13364) New Crowdin updates (JabRef#13363) Bump org.junit.jupiter:junit-jupiter-api in /versions (JabRef#13362) Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (JabRef#13359) Bump com.github.javaparser:javaparser-symbol-solver-core in /versions (JabRef#13361) Bump org.junit.platform:junit-platform-launcher in /versions (JabRef#13360) Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 in /versions (JabRef#13358) Gradle build updates (JabRef#13319) Add "Disable GitHub actions" (JabRef#13356) ...
ZodGaz
added a commit
to ZodGaz/jabref
that referenced
this pull request
Jun 20, 2025
…rewrote shouldShow in FileAnnotationTab as requested in JabRef#13279
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
* Refactor "enableFileAnnotationsTab" to "smartFileAnnotationsTab" and rewrote shouldShow in FileAnnotationTab as requested in #13279 * Fixes #13241, forcing a search refresh only when the fulltext flag is on, removing and re-adding the flag from the query when the database is switched. * CHANGELOG update * comment indent fix, added Javadoc style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13143
added a checkbox as described in the issue to not show the file annotation tab when annotations are not present in the entry files.
Steps to test
Screen.Recording.2025-06-08.at.18.25.17.mov
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)