Skip to content

Conversation

@priyanshu16095
Copy link
Contributor

@priyanshu16095 priyanshu16095 commented Jun 14, 2025

Refers #12364 (comment)

This PR enhances the part of the Ltwa.g4 grammar file which causes parsing issues on some Windows systems, making it compatible with Windows and ensuring proper interpretation of characters.

Steps to test

  • Fetch the latest changes.
  • Restart the JabRef, it will work.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr previously approved these changes Jun 14, 2025
| '\u00C0'..'\u00D6' // À–Ö
| '\u00D8'..'\u00F6' // Ø–ö
| '\u00F8'..'\u00FF' // ø–ÿ
| '\u0100'..'\u017F'
Copy link
Member

@Siedlerchr Siedlerchr Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment for the other unicode chars as well like you did?
you can find out about them at https://www.compart.com/de/unicode/U+0100

@trag-bot
Copy link

trag-bot bot commented Jun 14, 2025

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr Siedlerchr enabled auto-merge June 14, 2025 11:18
@Siedlerchr Siedlerchr added this pull request to the merge queue Jun 14, 2025
@koppor
Copy link
Member

koppor commented Jun 14, 2025

This surely was introduced by an ANTLR update. Did anyone find an issue at ANTLR or a changelog entry of them?

Merged via the queue into JabRef:main with commit dbbc96c Jun 14, 2025
1 check passed
Siedlerchr added a commit to FlyJoanne/jabref that referenced this pull request Jun 15, 2025
* upstream/main:
  New Crowdin updates (JabRef#13330)
  Add arm 64 linux runner (JabRef#13258)
  Rename strings and variables in New Entry (JabRef#13312)
  Let consistency checker yield a return code (JabRef#13329)
  Update LETTER fragment to resolve Windows parsing issue (JabRef#13327)
  Add support for "dev: no-bot-comments"
  Update dependency org.hibernate.validator:hibernate-validator to v9.0.1.Final (JabRef#13322)
  Endnote XML Exporter: Move factory initialization to constructor (JabRef#13321)
  Refine assignment reminder (JabRef#13315)
  Add welcome message to first time contributors (JabRef#13314)
  New Crowdin updates (JabRef#13311)
  Added a setting to show File annotations' tab only when the PDF actually contains highlights or comments (JabRef#13279)
  Update dependency org.postgresql:postgresql to v42.7.7 (JabRef#13306)
  Refine PULL_REQUEST_TEMPLATE.md (JabRef#13304)
  Move module tweaking of merged module to launcher (JabRef#13303)
  Speed up gradle update (JabRef#13300)
  testImplementation is enough (JabRef#13299)
@calixtus
Copy link
Member

Task :jablib:generateGrammarSource
warning(180): org\jabref\logic\journals\ltwa\Ltwa.g4::: chars 'A' used multiple times in set 'A'..'Z' | 'a'..'z'
warning(180): org\jabref\logic\journals\ltwa\Ltwa.g4::: chars 'a' used multiple times in set 'A'..'Z' | 'a'..'z'
warning(180): org\jabref\logic\journals\ltwa\Ltwa.g4::: chars '\u00E0' used multiple times in set 'A'..'Z' | 'a'..'z' | '\u00C0'..'\u00D6' | '\u00E0'..'\u00F6'

Siedlerchr added a commit to JustinHennis1/jabref that referenced this pull request Jun 16, 2025
* upstream/main:
  New Crowdin updates (JabRef#13330)
  Add arm 64 linux runner (JabRef#13258)
  Rename strings and variables in New Entry (JabRef#13312)
  Let consistency checker yield a return code (JabRef#13329)
  Update LETTER fragment to resolve Windows parsing issue (JabRef#13327)
  Add support for "dev: no-bot-comments"
  Update dependency org.hibernate.validator:hibernate-validator to v9.0.1.Final (JabRef#13322)
  Endnote XML Exporter: Move factory initialization to constructor (JabRef#13321)
  Refine assignment reminder (JabRef#13315)
  Add welcome message to first time contributors (JabRef#13314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants