Adapt some fetcher tests #13370
Merged
Adapt some fetcher tests #13370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: subhramit <[email protected]>
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| @Test | ||
| void searchByQueryFindsEntry() throws FetcherException { | ||
|
|
||
| BibEntry articleSupportingIdentification = new BibEntry(StandardEntryType.Article) |
There was a problem hiding this comment.
The BibEntry creation uses chained setField calls instead of a more concise builder pattern. Should use withField methods in a single chain for better readability.
Member
Author
There was a problem hiding this comment.
entire file has that pattern, hence did not touch
wait, what?
calixtus
reviewed
Jun 17, 2025
| assertEquals(Optional.of(barrosEntry), fetcher.performSearch(entry).stream().findFirst()); | ||
| } | ||
|
|
||
| @Disabled("As of June 2025, has a title") |
Member
There was a problem hiding this comment.
Can you check if you find another article without a title?
Signed-off-by: subhramit <[email protected]>
|
@trag-bot didn't find any issues in the code! ✅✨ |
calixtus
approved these changes
Jun 17, 2025
Siedlerchr
added a commit
to MiguelCBar/jabref
that referenced
this pull request
Jun 18, 2025
* upstream/main: (47 commits) Adapt some fetcher tests (JabRef#13370) change template issue number (JabRef#13367) Refine error message in URLUtil::create (JabRef#13337) fix deletion again (JabRef#13369) Only prevent failure in publishing from stopping the workflow (JabRef#13368) Refactor "enableFileAnnotationsTab" to "smartFileAnnotationsTab" and rewrote shouldShow in FileAnnotationTab as requested in JabRef#13279 (JabRef#13338) fix workflow (JabRef#13366) Fixamd64linux (JabRef#13365) Only delete for arm64 (JabRef#13364) New Crowdin updates (JabRef#13363) Bump org.junit.jupiter:junit-jupiter-api in /versions (JabRef#13362) Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (JabRef#13359) Bump com.github.javaparser:javaparser-symbol-solver-core in /versions (JabRef#13361) Bump org.junit.platform:junit-platform-launcher in /versions (JabRef#13360) Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 in /versions (JabRef#13358) Gradle build updates (JabRef#13319) Add "Disable GitHub actions" (JabRef#13356) Make jabref host executable on mac and on linux and fix import command line argument (JabRef#13355) Delete .github/workflows/merge-upstream.yml (JabRef#13357) chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.25.0 (JabRef#13353) ...
Siedlerchr
added a commit
to ganesh-vk/jabref
that referenced
this pull request
Jun 18, 2025
* upstream/main: (54 commits) Move publishing to maven central to a separate workflow (JabRef#13372) Add more guards to workflows not running on forked JabRef repos Copy real HTML from entry preview (JabRef#13339) Adapt some fetcher tests (JabRef#13370) change template issue number (JabRef#13367) Refine error message in URLUtil::create (JabRef#13337) fix deletion again (JabRef#13369) Only prevent failure in publishing from stopping the workflow (JabRef#13368) Refactor "enableFileAnnotationsTab" to "smartFileAnnotationsTab" and rewrote shouldShow in FileAnnotationTab as requested in JabRef#13279 (JabRef#13338) fix workflow (JabRef#13366) Fixamd64linux (JabRef#13365) Only delete for arm64 (JabRef#13364) New Crowdin updates (JabRef#13363) Bump org.junit.jupiter:junit-jupiter-api in /versions (JabRef#13362) Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (JabRef#13359) Bump com.github.javaparser:javaparser-symbol-solver-core in /versions (JabRef#13361) Bump org.junit.platform:junit-platform-launcher in /versions (JabRef#13360) Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 in /versions (JabRef#13358) Gradle build updates (JabRef#13319) Add "Disable GitHub actions" (JabRef#13356) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on devcall.
This does not solve 403s, 404s, too many requests, returned
Optional.emptys,[]s and server-side exceptions.Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)