Update spack submodule to include latest ufs-weather-model (package) updates and fiat tags#462
Conversation
srherbener
left a comment
srherbener
left a comment
There was a problem hiding this comment.
Thanks. I agree that this needs a proper testing to be completed before merging.
|
I tested on my M1 Mac using the arm64 architecture. Spack-stack built successfully, then jedi-bundle built successfully, and the subsequent ctest returned with 21 test failures. This is 9 less than what we have been seeing so something changed that allowed 9 more tests to pass! |
This is great, thanks very much! Let me try this on one a Linux system (AWS parallel cluster) before we merge it. |
|
@srherbener I tested this successfully on AWS parallelcluster with Intel, so I am going to merge the spack PR now and then update the submodule pointer in this PR. |
2 participants
Description
This PR updates the submodule pointer for spack for the changes in JCSDA/spack#217 (add
@developto ufs-weather-model) and JCSDA/spack#219 (fiattags).Issues
Working towards JCSDA/spack#28
Testing
This PR needs proper testing - not only to build, but also to run jedi-bundle (because the fiat tags that ECMWF created are slightly different hashes than what we used as "fake" 1.0.0 and 1.1.0 versions until now).