Add @develop to ufs-weather-model#217
Add @develop to ufs-weather-model#217AlexanderRichert-NOAA merged 5 commits intoJCSDA:jcsda_emc_spack_stackfrom
Conversation
…platform override and mom6solo variants; remove ESMFMKFILE setting
AlexanderRichert-NOAA
requested review from
Hang-Lei-NOAA,
climbfuji and
ulmononian
| "simdmultiarch", default=False, description="Enable multi-target SIMD instruction sets" | ||
| ) | ||
| variant("debug", default=False, description="Enable DEBUG mode", when="@develop") | ||
| variant( |
There was a problem hiding this comment.
Note that this horrible debug link mpi option needs to go away, it's not portable and not something we should be doing. @aerorahul @DusanJovic-NOAA and I have fought this bad practice for a while, but with moving to spack-stack we should really get rid of it.
| variant("moving_nest", default=False, description="Enable moving nest code", when="@develop") | ||
| variant("openmp", default=True, description="Enable OpenMP") | ||
| variant("parallel_netcdf", default=True, description="Enable parallel NetCDF") | ||
| variant( |
There was a problem hiding this comment.
I don't know if this option works at all, it's certainly not the way we integrate the UFS with JEDI here: JCSDA/ufs-bundle#9
@mark-a-potts @aerorahul Can you provide more information on this option?
| description="Enable atmosphere-ocean flux calculation in mediator", | ||
| when="@develop", | ||
| ) | ||
| variant( |
There was a problem hiding this comment.
Why is this a variant? Is there a way to build the UFS without CCPP physics?
|
@climbfuji For what it's worth, my overall approach has been to try to make variants match as closely as possible with what's provided in cmake (though I have not implemented every available switch from the various submodules, only the one or two that I seemed to need for doing RTs), and leaving the rest up to the user. So nothing here is necessarily a guarantee of the underlying functionality in UFS WM. |
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I assume you have tested those changes, I haven't. It looks ok to me, though I don't think the CCPP=false option will work.
2 participants
This PR makes significant revisions to the ufs-weather-model package. Namely, it adds a version for the head of the develop branch and has updates to variants and dependencies, as well as one or two patches.