Replace fiat hashes with actual tags#219
Merged
climbfuji merged 2 commits intoJCSDA:jcsda_emc_spack_stackfrom Feb 3, 2023
Merged
Replace fiat hashes with actual tags#219climbfuji merged 2 commits intoJCSDA:jcsda_emc_spack_stackfrom
climbfuji merged 2 commits intoJCSDA:jcsda_emc_spack_stackfrom
Conversation
srherbener
approved these changes
Feb 1, 2023
Collaborator
srherbener
left a comment
srherbener
left a comment
There was a problem hiding this comment.
Thanks for making this correction!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to send the ECMWF packages upstream to spack, we need hashes for
fiat- so far, there were not tags or releases. ECMWF created tags1.0.0and1.1.0as requested, but these are slightly different hashes than what we used as "fake"1.0.0and1.1.0versions until now. This PR updates thefiatpackage. We need to test thoroughly at least the currently used1.1.0release.