-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom backgrounds in Teams V2 #1226
Custom backgrounds in Teams V2 #1226
Conversation
35bf5ae
to
dfdecaf
Compare
It would be good if we change the default value of isCustomBackgroundEnabled as false as it can make the app confuse if you are running anything in port 80 (localhost), as that is the default value. As people needs to tinker with the configuration anyway for customBackground, adding an extra flag is not a big deal. Once you done that, if you can pull from develop and update the package.json and com.github.IsmaelMartinez.teams_for_linux.appdata.xml with version details? This should fix #1226 . Thanks a lot!! |
I just build a amd64 deb package from jonatasrs' custom-background-teams-v2 branch and after changing the format of the config.json on my server this works like a charm as in teams v1 before. |
@jonatasrs could you update |
dfdecaf
to
b10ebd3
Compare
Code updated with the requested information. |
Thanks @jonatasrs 🚀 @IsmaelMartinez, if you don't have further comments kindly merge it when you have time. |
Thanks a lot for the contribution @jonatasrs. Good job. Released under https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.4.36 |
Thanks for the change. Unfortunately it is not working for me. It always tries to load my custom image from https://statics.teams.cdn.office.net - what I am doing wrong? customBGServiceBaseUrl is set and isCustomBackgroundEnabled on true. Update: Works now, I was not aware, that I need this "/evergreen-assets/backgroundimages/" prefix in front of my image settings, even if I don't have these structure. |
Yes, this was a quick implementation just to get things working. It's not very good, but it works. This can be improved with a little more work. |
Teams V2 changed the image and configuration search url to: https://statics.teams.cdn.office.net/evergreen-assets/backgroundimages/config.json?v=6
This implementation only replaces the root url (https://statics.teams.cdn.office.net/evergreen-assets/backgroundimages/) to fetch the local custom images.
This will replace Microsoft's default images.
To use standard Microsoft images, you must activate the flag --isCustomBackgroundEnabled=false
Fix #1167