Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom backgrounds in Teams V2 #1226

Merged

Conversation

jonatasrs
Copy link
Contributor

Teams V2 changed the image and configuration search url to: https://statics.teams.cdn.office.net/evergreen-assets/backgroundimages/config.json?v=6

This implementation only replaces the root url (https://statics.teams.cdn.office.net/evergreen-assets/backgroundimages/) to fetch the local custom images.

This will replace Microsoft's default images.

To use standard Microsoft images, you must activate the flag --isCustomBackgroundEnabled=false

Fix #1167

@jonatasrs jonatasrs force-pushed the custom-background-teams-v2 branch from 35bf5ae to dfdecaf Compare May 2, 2024 13:39
@IsmaelMartinez
Copy link
Owner

It would be good if we change the default value of isCustomBackgroundEnabled as false as it can make the app confuse if you are running anything in port 80 (localhost), as that is the default value. As people needs to tinker with the configuration anyway for customBackground, adding an extra flag is not a big deal.

Once you done that, if you can pull from develop and update the package.json and com.github.IsmaelMartinez.teams_for_linux.appdata.xml with version details?

This should fix #1226 . Thanks a lot!!

@RolandRosenfeld
Copy link

I just build a amd64 deb package from jonatasrs' custom-background-teams-v2 branch and after changing the format of the config.json on my server this works like a charm as in teams v1 before.
Also the option --isCustomBackgroundEnabled=false works as expected and brings back the default backgrounds (instead of my custom backgrounds).
It would be great to have this merged to the official release.

@jijojosephk
Copy link
Collaborator

@jonatasrs could you update package.json and com.github.IsmaelMartinez.teams_for_linux.appdata.xml with version information?

@jonatasrs jonatasrs force-pushed the custom-background-teams-v2 branch from dfdecaf to b10ebd3 Compare May 3, 2024 12:46
@jonatasrs
Copy link
Contributor Author

Code updated with the requested information.

@jijojosephk
Copy link
Collaborator

Thanks @jonatasrs 🚀

@IsmaelMartinez, if you don't have further comments kindly merge it when you have time.

@IsmaelMartinez IsmaelMartinez merged commit f0c2825 into IsmaelMartinez:develop May 3, 2024
3 of 4 checks passed
@IsmaelMartinez
Copy link
Owner

IsmaelMartinez commented May 3, 2024

Thanks a lot for the contribution @jonatasrs. Good job. Released under https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.4.36

@limes007
Copy link

limes007 commented May 13, 2024

Thanks for the change. Unfortunately it is not working for me. It always tries to load my custom image from https://statics.teams.cdn.office.net - what I am doing wrong? customBGServiceBaseUrl is set and isCustomBackgroundEnabled on true.

Update: Works now, I was not aware, that I need this "/evergreen-assets/backgroundimages/" prefix in front of my image settings, even if I don't have these structure.

@jonatasrs
Copy link
Contributor Author

Yes, this was a quick implementation just to get things working. It's not very good, but it works. This can be improved with a little more work.

@jonatasrs jonatasrs deleted the custom-background-teams-v2 branch May 13, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom video bgs not working
5 participants