Custom video bgs not working

[banholzer]

Describe the bug
Custom video backgrounds are not showing - not even the thumbs are showing up.

To Reproduce

1. starting from cli

❯ teams-for-linux --optInTeamsV2
[WARN] No config file found, using default values
[ERROR] Failed to save remote configuration at '/<homedir>/.config/teams-for-linux/custom_bg_remote.json'

while <homedir> is the actual directory where my home-directory is.
2. Images not showing up in background effects view.

Expected behavior
Custom images showing up - worked in previous versions. Apache config & content was not changed.

Screenshots

Desktop (please complete the following information):
Environment: Ubuntu 22.04 with KDE Plasma Desktop

❯ dpkg -l teams-for-linux | grep teams-for-linux
ii  teams-for-linux 1.4.17       amd64        Teams for Linux

• Version 1.4.17 pre-release

Additional context
was not yet able to rollback and test with older version. Already cleared local storage - no change. Also deleted complete .config/teams-for-linux/ - no change.

[IsmaelMartinez]

I suspect this is related to teams-v2 move as they will probably have changed stuff.

However, the log error looks more of a permissions issue that the later. Anybody help??

[DerXteMensch]

Custom backgrounds were working for me for many months. But the moment I switch to teams v2, they don't work anymore. See also #1171

[DerXteMensch]

With an older version (I think v1.4.14, but I'm not all sure) it didn't work either with teams v2, only with teams v1. Switched today from (probably) 1.4.14 to 1.4.17

[IsmaelMartinez]

Is probably the URL then! Worth checking if the urls still march the ones in https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/app/mainAppWindow/index.js#L247

[ajoergensen]

It looks like the background images are fetched from https://statics.teams.cdn.office.net/evergreen-assets/backgroundimages/

[IsmaelMartinez]

Ok, I think this is related to the move from angular to react that is probably breaking this file:

https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/app/browser/tools/customBackgrounds.js

but it looks like Microsoft is not supporting custom backgrounds yet in the new teamsv2 so this issue is blocked. Sorry!

[banholzer]

today switched back to 1.4.13 which I thought worked before - still seeing same behavior

reverted to teamsv1

and deleted .config/teams-for-linux/

❯ teams-for-linux
[ERROR] Failed to save remote configuration at '/.../.config/teams-for-linux/custom_bg_remote.json'
❯ teams-for-linux --version
1.4.13

same with 1.4.12 - probably the issue is somewhere on how Microsoft code searches for the images

[DerXteMensch]

So I'll stay as long as it is possible with teams v1

[jkrysakowski]

I just managed to run a custom background. Hint: the domain that serves the config and bg files must support https://

I see a bug: the background image is flipped horizontally

[calebdw]

I just managed to run a custom background. Hint: the domain that serves the config and bg files must support https://

This is still only on v1 and not v2, I am unable to get the custom background images working even with https support

[IsmaelMartinez]

If anyone is skilled in front end dev (just a bit) It Might be worth checking around the objects in the React handler file. I did see some "last background effect" and stuff like that, but had no time to look at it. It was an object with a URL, name and/or path (I think) so it might work.

…

On Mon, 8 Apr 2024, 18:10 Caleb White, ***@***.***> wrote: I just managed to run a custom background. Hint: the domain that serves the config and bg files must support https:// This is still only on v1 and not v2, I am unable to get the custom background images working even with https support — Reply to this email directly, view it on GitHub <#1167 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADJHEAMEFWNPO6TRVN5CF3Y4LFQJAVCNFSM6AAAAABFUVI5BCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTGI3DCOJSHE> . You are receiving this because you commented.Message ID: ***@***.***>

[derekatkins]

My org just forced me to upgrade to Teams v2 and now I'm hitting this bug. My --customBGServiceBaseUrl=https://my.custom/url which worked a weekk ago isn't working now that teams got updated.

[derekatkins]

It's not even hitting my link, so it's not even attempting to download the config.json file.

[jijojosephk]

We'll add more logs to help debugging.

[Cybso]

I assume it's related to this error message in the web debug console:

Failed to override MS Method
error @ v2/:3
(anonymous) @ /opt/teams-for-linux/resources/app.asar/app/browser/tools/customBackgrounds.js:21

Edit: I managed to get the error message, it is 'Failed to get app objects after 5 tries'

[jijojosephk]

Existing implementation is dependent on angular based teams app v1. With the new version, it will not work.

[banholzer]

should we then close this issue for that reason?

[jijojosephk]

We can keep it until we find a solution with latest version of teams.

[jonatasrs]

Any work in progress on this?

[IsmaelMartinez]

I am afraid no, at the moment this is just not working and unfortunately I don't have time to look at it, whoever I encourage anyone to have a look.

In the meantime, you can use OBS as described in #1215 (comment) . Not ideal but a workaround.

[jonatasrs]

Thanks for the answer, I added this pull request #1226

[IsmaelMartinez]

legend! Left a wee comment. I will probably try to release it with #1228 and https://github.com/IsmaelMartinez/teams-for-linux/pull/1224/files as a pre-release early next week. (No point of having 3 small releases when the code touches different parts). Thanks again and good finding!

[limes007]

@jonatasrs Great, thank you.

[derekatkins]

Indeed, thank you.
By my reading of the patch, v2 uses a different JSON format than v1 -- correct?

[DerXteMensch]

Unfortunately I was forced to switch to Teams v2 today. Is there a pre-release yet?

Edit: After a restart of Teams, it started with v1 again... Nevertheless I'm looking forward to a pre-release

[IsmaelMartinez]

can one of you try the MR in #1226 ? Got a small open question but it will be good if one of you can validate that is the fix. Thanks!