Skip to content

Conversation

@Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Sep 25, 2025

Depends on: IntersectMBO/cardano-api#962

Changelog

- description: |
    Deprecate certificate
  type:
  - compatible     # the API has changed but is non-breaking

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/final-deprecate-certificate branch 2 times, most recently from b387201 to 8f23987 Compare September 25, 2025 11:06
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll approve after we deal with CLI version for node 10.6

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity.

@Jimbo4350 Jimbo4350 force-pushed the jordan/final-deprecate-certificate branch from 0dff1ab to 8b55bed Compare November 18, 2025 19:15
@Jimbo4350 Jimbo4350 force-pushed the jordan/final-deprecate-certificate branch from 8b55bed to 70ddf49 Compare November 18, 2025 19:33
@Jimbo4350 Jimbo4350 requested a review from a team as a code owner November 19, 2025 12:49
@Jimbo4350 Jimbo4350 force-pushed the jordan/final-deprecate-certificate branch from 897ebff to 1d1b4eb Compare November 19, 2025 12:55
@Jimbo4350 Jimbo4350 force-pushed the jordan/final-deprecate-certificate branch from 1d1b4eb to c4f863a Compare November 19, 2025 19:47
@Jimbo4350 Jimbo4350 force-pushed the jordan/final-deprecate-certificate branch from c4f863a to 03383b7 Compare November 20, 2025 12:30
@Jimbo4350 Jimbo4350 force-pushed the jordan/final-deprecate-certificate branch from 03383b7 to 8859796 Compare November 20, 2025 12:49
Convert this test to a simple certificate decoding test and move the
test to cardano-cli-test
@Jimbo4350 Jimbo4350 enabled auto-merge November 20, 2025 13:43
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Nov 20, 2025
Merged via the queue into master with commit a4e098a Nov 20, 2025
25 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/final-deprecate-certificate branch November 20, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants