-
Notifications
You must be signed in to change notification settings - Fork 22
Deprecate certificate #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Deprecate certificate #1286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b387201 to
8f23987
Compare
carbolymer
reviewed
Sep 25, 2025
...i/test/cardano-cli-golden/files/golden/governance/stakeaddress/poolAndNoConfidenceDeleg.cert
Show resolved
Hide resolved
carbolymer
reviewed
Sep 25, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll approve after we deal with CLI version for node 10.6
|
This PR is stale because it has been open 45 days with no activity. |
This was referenced Nov 13, 2025
8f23987 to
0dff1ab
Compare
0dff1ab to
8b55bed
Compare
8b55bed to
70ddf49
Compare
897ebff to
1d1b4eb
Compare
1d1b4eb to
c4f863a
Compare
carbolymer
approved these changes
Nov 20, 2025
c4f863a to
03383b7
Compare
03383b7 to
8859796
Compare
Convert this test to a simple certificate decoding test and move the test to cardano-cli-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: IntersectMBO/cardano-api#962
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist