Skip to content

Deprecate certificate #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 20, 2025
Merged

Deprecate certificate #1286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
02d4cf6
Propagate new api's experimental certificate type
Jimbo4350 Sep 23, 2025
e0df02e
Update friendly rendering of certificates
Jimbo4350 Sep 23, 2025
a277ee4
Certificate deprecation changes
Jimbo4350 Nov 17, 2025
14f4f63
Bump CHaP index and bump to cardano-api-10.20.0.0
Jimbo4350 Nov 18, 2025
adde483
Bump nix flake
Jimbo4350 Nov 19, 2025
270acc0
Use legacyComparison
Jimbo4350 Nov 19, 2025
18ce549
Replace checkTextEnvelopeFormat with diffFileVsGoldenFile
Jimbo4350 Nov 19, 2025
8859796
Update golden files as we are using the new Certificate type
Jimbo4350 Nov 19, 2025
fc6b6b2
The genesis key delegation certificate test was never a golden test
Jimbo4350 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cabal.project
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ repository cardano-haskell-packages
-- you need to run if you change them
index-state:
, hackage.haskell.org 2025-11-05T09:40:54Z
, cardano-haskell-packages 2025-11-05T10:16:35Z
, cardano-haskell-packages 2025-11-18T18:44:49Z

packages:
cardano-cli
Expand Down
4 changes: 2 additions & 2 deletions cardano-cli/cardano-cli.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ library
binary,
bytestring,
canonical-json,
cardano-api ^>=10.19.1,
cardano-api ^>=10.20,
cardano-binary,
cardano-crypto,
cardano-crypto-class ^>=2.2,
Expand Down Expand Up @@ -387,6 +387,7 @@ test-suite cardano-cli-test
build-tool-depends: tasty-discover:tasty-discover
other-modules:
Test.Cli.AddCostModels
Test.Cli.Certificates.GenesisKeyDelegationCertificate
Test.Cli.Certificates.StakePool
Test.Cli.CheckNodeConfiguration
Test.Cli.Compatible.StakeAddress.DelegationCertificate
Expand Down Expand Up @@ -507,7 +508,6 @@ test-suite cardano-cli-golden
Test.Golden.Shelley.StakeAddress.KeyHash
Test.Golden.Shelley.StakeAddress.RegistrationCertificate
Test.Golden.Shelley.StakePool.RegistrationCertificate
Test.Golden.Shelley.TextEnvelope.Certificates.GenesisKeyDelegation
Test.Golden.Shelley.TextEnvelope.Certificates.Operational
Test.Golden.Shelley.TextEnvelope.Keys.ExtendedPaymentKeys
Test.Golden.Shelley.TextEnvelope.Keys.GenesisDelegateKeys
Expand Down
1 change: 0 additions & 1 deletion cardano-cli/src/Cardano/CLI/Compatible/Governance/Command.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ data CompatibleGovernanceCmds era
Coin
(File () Out)
| CompatibleGenesisKeyDelegationCertificate
(ShelleyToBabbageEra era)
(VerificationKeyOrHashOrFile GenesisKey)
(VerificationKeyOrHashOrFile GenesisDelegateKey)
(VerificationKeyOrHashOrFile VrfKey)
Expand Down
15 changes: 6 additions & 9 deletions cardano-cli/src/Cardano/CLI/Compatible/Governance/Option.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ pCompatibleGovernanceCmds sbe =
]
)
[ pCreateMirCertificatesCmds sbe
, pGovernanceGenesisKeyDelegationCertificate sbe
, pGovernanceGenesisKeyDelegationCertificate
, fmap CreateCompatibleProtocolParametersUpdateCmd <$> pGovernanceActionCmds sbe
]
)
Expand Down Expand Up @@ -119,19 +119,16 @@ pUpdateProtocolParametersPreConway shelleyToBab =
<*> pProtocolParametersUpdateGenesisKeys

pGovernanceGenesisKeyDelegationCertificate
:: ()
=> ShelleyBasedEra era
-> Maybe (Parser (CompatibleGovernanceCmds era))
pGovernanceGenesisKeyDelegationCertificate sbe = do
w <- forShelleyBasedEraMaybeEon sbe
:: Maybe (Parser (CompatibleGovernanceCmds era))
pGovernanceGenesisKeyDelegationCertificate = do
pure $
Opt.hsubparser $
commandWithMetavar "create-genesis-key-delegation-certificate" $
Opt.info (parser w) $
Opt.info parser $
Opt.progDesc "Create a genesis key delegation certificate"
where
parser w =
CompatibleGenesisKeyDelegationCertificate w
parser =
CompatibleGenesisKeyDelegationCertificate
<$> pGenesisVerificationKeyOrHashOrFile
<*> pGenesisDelegateVerificationKeyOrHashOrFile
<*> pVrfVerificationKeyOrHashOrFile
Expand Down
6 changes: 3 additions & 3 deletions cardano-cli/src/Cardano/CLI/Compatible/Governance/Run.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ import Cardano.CLI.Type.Error.GovernanceActionsError

import Data.Typeable (Typeable)

runCompatibleGovernanceCmds :: Typeable era => CompatibleGovernanceCmds era -> CIO e ()
runCompatibleGovernanceCmds :: CompatibleGovernanceCmds era -> CIO e ()
runCompatibleGovernanceCmds = \case
CreateCompatibleProtocolParametersUpdateCmd cmd ->
runCompatibleGovernanceActionCreateProtocolParametersUpdateCmd cmd
LatestCompatibleGovernanceCmds cmd -> runGovernanceCmds cmd
CompatibleGenesisKeyDelegationCertificate sta genVk genDelegVk vrfVk out ->
runGovernanceGenesisKeyDelegationCertificate sta genVk genDelegVk vrfVk out
CompatibleGenesisKeyDelegationCertificate genVk genDelegVk vrfVk out ->
runGovernanceGenesisKeyDelegationCertificate genVk genDelegVk vrfVk out
CompatibleCreateMirCertificateStakeAddressesCmd w mirpot vKeys rewards out ->
runGovernanceMIRCertificatePayStakeAddrs w mirpot vKeys rewards out
CompatibleCreateMirCertificateTransferToReservesCmd w ll oFp ->
Expand Down
Loading
Loading