Fix golden tests

Jimbo4350 · Jimbo4350 · commit 8b55bed8e46b · 2025-11-18T15:15:23.000-04:00
diff --git a/cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/Committee.hs b/cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/Committee.hs
@@ -116,7 +116,7 @@ hprop_golden_governance_CommitteeCreateHotKeyAuthorizationCertificate =
         ]
 
     assertHasMappings
-      [ ("type", "CertificateConway")
+      [ ("type", "Certificate")
       , ("description", "Constitutional Committee Hot Key Registration Certificate")
       ]
       certFile
@@ -156,7 +156,7 @@ hprop_golden_governance_CommitteeCreateColdKeyResignationCertificate =
         ]
 
     assertHasMappings
-      [ ("type", "CertificateConway")
+      [ ("type", "Certificate")
       , ("description", "Constitutional Committee Cold Key Resignation Certificate")
       ]
       certFile
diff --git a/cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Certificates/GenesisKeyDelegation.hs b/cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Certificates/GenesisKeyDelegation.hs
@@ -2,13 +2,6 @@
 
 module Test.Golden.Shelley.TextEnvelope.Certificates.GenesisKeyDelegation where
 
-import Cardano.Api
-  ( AsType (..)
-  , CardanoEra (..)
-  , cardanoEraConstraints
-  , textEnvelopeTypeInEra
-  )
-
 import Control.Monad (void)
 
 import Test.Cardano.CLI.Util
@@ -20,8 +13,6 @@ import Hedgehog.Extras.Test.File qualified as H
 hprop_golden_shelleyGenesisKeyDelegationCertificate :: Property
 hprop_golden_shelleyGenesisKeyDelegationCertificate =
   watchdogProp . propertyOnce . H.moduleWorkspace "tmp" $ \tempDir -> do
-    let era = BabbageEra
-
     -- Reference certificate
     referenceCertificateFilePath <-
       noteInputFile $
@@ -106,8 +97,8 @@ hprop_golden_shelleyGenesisKeyDelegationCertificate =
         ]
 
     H.assertFilesExist [genesisKeyDelegCertFilePath]
-
-    let certificateType = cardanoEraConstraints era $ textEnvelopeTypeInEra era AsCertificate
+    -- TODO: Left off here. You need to expose textEnvelopeTypeInEra for experimental
+    let certificateType = "Certificate"
 
     checkTextEnvelopeFormat
       certificateType
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/governance/drep/drep_registration_certificate.json b/cardano-cli/test/cardano-cli-golden/files/golden/governance/drep/drep_registration_certificate.json
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "DRep Key Registration Certificate",
     "cborHex": "84108200581ceb09d5556a8bce421074e394d02c79ced96741657b4cf7ca8995294d00826964756d6d792d75726c582052e69500a92d80f2126c836a4903dc582006709f004cf7a28ed648f732dff8d2"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/governance/drep/drep_registration_certificate_script.json b/cardano-cli/test/cardano-cli-golden/files/golden/governance/drep/drep_registration_certificate_script.json
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "DRep Script Registration Certificate",
     "cborHex": "84108201581c0000000000000000000000000000000000000000000000000000000300826964756d6d792d75726c582052e69500a92d80f2126c836a4903dc582006709f004cf7a28ed648f732dff8d2"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/governance/drep/drep_retirement_cert b/cardano-cli/test/cardano-cli-golden/files/golden/governance/drep/drep_retirement_cert
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "DRep Key Retirement Certificate",
     "cborHex": "83118200581ceb09d5556a8bce421074e394d02c79ced96741657b4cf7ca8995294d1a000f4240"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/governance/drep/drep_update_certificate.json b/cardano-cli/test/cardano-cli-golden/files/golden/governance/drep/drep_update_certificate.json
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "DRep Key Update Certificate",
     "cborHex": "83128200581ceb09d5556a8bce421074e394d02c79ced96741657b4cf7ca8995294d826964756d6d792d75726c582052e69500a92d80f2126c836a4903dc582006709f004cf7a28ed648f732dff8d2"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/governance/drep/drep_update_certificate_script_hash.json b/cardano-cli/test/cardano-cli-golden/files/golden/governance/drep/drep_update_certificate_script_hash.json
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "DRep Script Update Certificate",
     "cborHex": "83128201581c8f33600845940d65bdbc7ea7a247a7997aa8558649128fa82c4c046882785e68747470733a2f2f7261772e67697468756275736572636f6e74656e742e636f6d2f63617264616e6f2d666f756e646174696f6e2f434950732f6d61737465722f4349502d303131392f6578616d706c65732f647265702e6a736f6e6c645820fecc1773db89b45557d82e07719c275f6877a6cadfd2469f4dc5a7df5b38b4a4"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/governance/stakeaddress/registerAddressDelegateToDrep.cert b/cardano-cli/test/cardano-cli-golden/files/golden/governance/stakeaddress/registerAddressDelegateToDrep.cert
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "Stake address registration and vote delegation certificate",
     "cborHex": "840c8200581cef1785cf18928f8353c90e76b7a8fc60855472d31a0ea1c1c774ab018200581ce68f9ee70599cb93d9f60678f9c6463c01938c27d9820c7bf93887a51a001e8480"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/governance/stakeaddress/registerAddressDelegateToPool.cert b/cardano-cli/test/cardano-cli-golden/files/golden/governance/stakeaddress/registerAddressDelegateToPool.cert
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "Stake address registration and stake delegation certificate",
     "cborHex": "840b8200581cef1785cf18928f8353c90e76b7a8fc60855472d31a0ea1c1c774ab01581cc27cf021914a2b3bcb286d3d741979083422378c577fe757702b69881a001e8480"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/governance/stakeaddress/registerAddressDelegateToPoolAndDrep.cert b/cardano-cli/test/cardano-cli-golden/files/golden/governance/stakeaddress/registerAddressDelegateToPoolAndDrep.cert
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "Stake address registration and vote delegation certificate",
     "cborHex": "850d8200581cef1785cf18928f8353c90e76b7a8fc60855472d31a0ea1c1c774ab01581cc27cf021914a2b3bcb286d3d741979083422378c577fe757702b69888200581ce68f9ee70599cb93d9f60678f9c6463c01938c27d9820c7bf93887a51a001e8480"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/shelley/dereg-cert-1.json b/cardano-cli/test/cardano-cli-golden/files/golden/shelley/dereg-cert-1.json
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "Stake Address Deregistration Certificate",
     "cborHex": "83088200581c81b4245f84593f63c0ff2296930254f77a0690fa9de5f969cac27cb01a001e8480"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/shelley/dereg-cert-2.json b/cardano-cli/test/cardano-cli-golden/files/golden/shelley/dereg-cert-2.json
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "Stake Address Deregistration Certificate",
     "cborHex": "83088201581cb9ff787a6dedf9ebe602a26352803778805428c7521b99ec7542aa011a001e8480"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/shelley/reg-certificate-extended.json b/cardano-cli/test/cardano-cli-golden/files/golden/shelley/reg-certificate-extended.json
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "Stake Pool Registration Certificate",
     "cborHex": "8a03581c1ae194ffedb008b77bfb8ec39b1514dbeb99ceccd66448181295142258206aa5f600f54659d456dc2628997df23d98f8f85681edd3e6f4a9340cb06b8db70000d81e820001581de0749440f878a5ba2ac3ab03dbdec6ae3ad5c89f06fc9c031611947803d9010281581c749440f878a5ba2ac3ab03dbdec6ae3ad5c89f06fc9c03161194780380f6"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/shelley/reg-certificate.json b/cardano-cli/test/cardano-cli-golden/files/golden/shelley/reg-certificate.json
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "Stake Pool Registration Certificate",
     "cborHex": "8a03581c4124a0c2ba8a7ba05824b3df23f706a1c8b3239446ab16709ae85aa158206aa5f600f54659d456dc2628997df23d98f8f85681edd3e6f4a9340cb06b8db70000d81e820001581de0749440f878a5ba2ac3ab03dbdec6ae3ad5c89f06fc9c031611947803d9010281581c749440f878a5ba2ac3ab03dbdec6ae3ad5c89f06fc9c03161194780380f6"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/shelley/stake-address/reg-certificate-1.json b/cardano-cli/test/cardano-cli-golden/files/golden/shelley/stake-address/reg-certificate-1.json
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "Stake Address Registration Certificate",
     "cborHex": "83078200581c81b4245f84593f63c0ff2296930254f77a0690fa9de5f969cac27cb01a001e8480"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/shelley/stake-address/reg-certificate-2.json b/cardano-cli/test/cardano-cli-golden/files/golden/shelley/stake-address/reg-certificate-2.json
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "Stake Address Registration Certificate",
     "cborHex": "83078200581c81b4245f84593f63c0ff2296930254f77a0690fa9de5f969cac27cb01a001e8480"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/shelley/stake-address/script-reg-certificate.json b/cardano-cli/test/cardano-cli-golden/files/golden/shelley/stake-address/script-reg-certificate.json
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateConway",
+    "type": "Certificate",
     "description": "Stake Address Registration Certificate",
     "cborHex": "83078201581cb9ff787a6dedf9ebe602a26352803778805428c7521b99ec7542aa011a001e8480"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/input/governance/hot-auth.cert b/cardano-cli/test/cardano-cli-golden/files/input/governance/hot-auth.cert
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateShelley",
+    "type": "Certificate",
     "description": "Constitutional Committee Hot Key Registration Certificate",
     "cborHex": "830e8200581c9c0682d5a71b1496ccbe4a79c332fcbc7cb317ec3b8faf6d45723e408200581cbb0fe4aca8548f6fd2050e5bd1b419d12bac166f3719b4959f323908"
 }
diff --git a/cardano-cli/test/cardano-cli-golden/files/input/shelley/certificates/genesis_key_delegation_certificate b/cardano-cli/test/cardano-cli-golden/files/input/shelley/certificates/genesis_key_delegation_certificate
@@ -1,5 +1,5 @@
 {
-    "type": "CertificateShelley",
+    "type": "Certificate",
     "description": "Genesis Key Delegation Certificate",
     "cborHex": "8405581cc3db461200fa59c81a4ecc8495446d9e42de27483ff6ee4339c9ab94581cd52ac434259f2af7fd2a538ece5ef8d80386527aa93e207473acb31c58201b9de69baec0dff8dde6e81d71f40f8b65fb3df55bb6ece5783aade88b17354d"
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ hprop_golden_governance_CommitteeCreateHotKeyAuthorizationCertificate =`
`116`	`116`	`]`
`117`	`117`
`118`	`118`	`assertHasMappings`
`119`		`- [ ("type", "CertificateConway")`
	`119`	`+ [ ("type", "Certificate")`
`120`	`120`	`, ("description", "Constitutional Committee Hot Key Registration Certificate")`
`121`	`121`	`]`
`122`	`122`	`certFile`
`@@ -156,7 +156,7 @@ hprop_golden_governance_CommitteeCreateColdKeyResignationCertificate =`
`156`	`156`	`]`
`157`	`157`
`158`	`158`	`assertHasMappings`
`159`		`- [ ("type", "CertificateConway")`
	`159`	`+ [ ("type", "Certificate")`
`160`	`160`	`, ("description", "Constitutional Committee Cold Key Resignation Certificate")`
`161`	`161`	`]`
`162`	`162`	`certFile`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "type": "CertificateConway",`
	`2`	`+ "type": "Certificate",`
`3`	`3`	`"description": "DRep Key Registration Certificate",`
`4`	`4`	`"cborHex": "84108200581ceb09d5556a8bce421074e394d02c79ced96741657b4cf7ca8995294d00826964756d6d792d75726c582052e69500a92d80f2126c836a4903dc582006709f004cf7a28ed648f732dff8d2"`
`5`	`5`	`}`