Skip to content

Conversation

@doronhi
Copy link
Contributor

@doronhi doronhi commented Feb 7, 2021

related to #1664
based on @joelbudu's #1668, set _msg_pointcloud.width before resize.
I prefer this implementation as it's shorter and contains fewer if-else cases.
If you approve, I'll try to add a unit-test based on the example from @mferenduros before merging.

@joelbudu
Copy link

joelbudu commented Feb 7, 2021

@doronhi, I agree this is a much more elegant solution. The unit-test would also be a great addition. Thank you

@doronhi
Copy link
Contributor Author

doronhi commented Feb 8, 2021

Couldn't find a wrapper for pcl::fromROSMsg in python and since my current unit tests are in python a unit-test for this will have to wait a little longer. Merging as it is.

@doronhi doronhi merged commit 7913abe into IntelRealSense:development Feb 8, 2021
@joelbudu
Copy link

joelbudu commented Feb 8, 2021

Thanks for this @doronhi . Is it possible to merge into the eloquent branch as well? I know it's EOL but it's what we're using currently for Ubuntu 18.04. Would be grateful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants