STYLE: Call itk.ParameterObject.GetDefaultParameterMap the static way

[N-Dekker]

In C++, GetDefaultParameterMap is a static member function of the ParameterObject class, and in Python, it does indeed have a @staticmethod decorator (looking at "site-packages\itk\elxParameterObjectPython.py"), so it can also be called "in the static way", without using an instance of ParameterObject.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[N-Dekker]

• I think this pull request is ready. The CI failures are unrelated, as far as I can see. Specifically the clang-format linter / lint (pull_request) failure is addressed by pull request COMP: Replace main with master in yml files of ".github\workflows" #352

[dzenanz]

Agreed. Merge unless you want to wait for Matt's review.

[N-Dekker]

Agreed. Merge unless you want to wait for Matt's review.

Thanks, @dzenanz.

• It appears that pylint doesn't really detect such cases, as I understand from issue Warn for static method called on an object pylint-dev/pylint#7705 However, I do agree with Marco Capuccini (@mcapuccini), the submitter of this pylint issue.

As a follow-up I'm considering to replace code like:

parameter_object = itk.ParameterObject.New()
parameter_map = parameter_object.GetDefaultParameterMap('rigid',3)
parameter_object.AddParameterMap(parameter_map)

with:

parameter_map = parameter_object.GetDefaultParameterMap('rigid',3)
parameter_object = itk.ParameterObject.New(parameter_map = parameter_map)

Or even

parameter_object = itk.ParameterObject.New(parameter_map = parameter_object.GetDefaultParameterMap('rigid',3))

Less is more 😺

[thewtex]

thanks @N-Dekker !

parameter_map = parameter_object.GetDefaultParameterMap('rigid',3)
parameter_object = itk.ParameterObject.New(parameter_map = parameter_map)

I think this is the best combination of conciseness and readability.

Per standard Python style, parameter_map=parameter_map.

[thewtex]

CI failures seem unrelated.