Skip to content

CustomOrMultipleParameterMaps example: Update output and call WriteParameterFile the static way#378

Merged
thewtex merged 2 commits intoInsightSoftwareConsortium:mainfrom
N-Dekker:ITK_Example02_CustomOrMultipleParameterMaps-WriteParameterFile-fixes
Mar 16, 2026
Merged

CustomOrMultipleParameterMaps example: Update output and call WriteParameterFile the static way#378
thewtex merged 2 commits intoInsightSoftwareConsortium:mainfrom
N-Dekker:ITK_Example02_CustomOrMultipleParameterMaps-WriteParameterFile-fixes

Conversation

@N-Dekker
Copy link
Collaborator

@N-Dekker N-Dekker commented Mar 15, 2026

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

When running "ITK_Example02_CustomOrMultipleParameterMaps.ipynb", the WriteParameterFile calls no longer produces such trailing `.000000` on floating point parameter values.

This is because of the improved way elastix writes floating points: pull request SuperElastix/elastix#934 commit SuperElastix/elastix@5c450b6, "ENH: `WriteParameterFile` write floating points without rounding errors", merged on Jul 12, 2023.

Updated GridSpacingSchedule values, following elastix pull request SuperElastix/elastix#1361 commit SuperElastix/elastix@6f031a5 "ENH: Reduce rounding errors "GridSpacingSchedule" GetDefaultParameterMap"
Follow-up to pull request InsightSoftwareConsortium#351 commit 6d377a2 "STYLE: Call `itk.ParameterObject.GetDefaultParameterMap` the static way"
@N-Dekker N-Dekker force-pushed the ITK_Example02_CustomOrMultipleParameterMaps-WriteParameterFile-fixes branch from 0af8c5c to 13c19fd Compare March 15, 2026 15:21
@N-Dekker N-Dekker marked this pull request as ready for review March 15, 2026 22:13
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thewtex thewtex merged commit 7394bbe into InsightSoftwareConsortium:main Mar 16, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants