FUTURE_LEGACY_REMOVE InternalPixelPointerType, EdgeListPointerType, InputBoundaryConditionPointerType#4554
Merged
thewtex merged 5 commits intoInsightSoftwareConsortium:masterfrom May 22, 2024
Conversation
Deprecated `InternalPixelPointerType`, which appears unused and untested anyway. Follow-up to pull request InsightSoftwareConsortium#4538 commit f44304d "STYLE: FUTURE_LEGACY_REMOVE BoundaryConditionPointerType type aliases"
Made it clearer that `QuadEdgeMeshBoundaryEdgesMeshFunction` just use a _raw_ pointer (not a smart pointer) to the edge list.
Follow-up to pull request InsightSoftwareConsortium#4538 commit f44304d "STYLE: FUTURE_LEGACY_REMOVE BoundaryConditionPointerType type aliases"
Replaced InputBoundaryConditionPointerType with `BoundaryConditionType *`. Aims to make it clearer that `DiscreteGaussianImageFilter` just has a _raw_ pointer (not a smart pointer) to the input `BoundaryCondition`.
Deprecated `DiscreteGaussianImageFilter::InputBoundaryConditionPointerType`. Follow-up to pull request InsightSoftwareConsortium#4538 commit f44304d "STYLE: FUTURE_LEGACY_REMOVE BoundaryConditionPointerType type aliases"
github-actions
bot
added
area:Core
Member
|
Please keep for this for after 5.4.0 has been released. |
N-Dekker
changed the title
N-Dekker
changed the title
Contributor
Author
|
I think this pull request may also be merged now, as v5.4.0 has been tagged: #4603 (comment) |
thewtex
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated the following three typedefs of raw pointer types:
It appears clearer to just use the
Type *syntax, to explicitly make clear when using a raw pointer, rather than a smart pointer.These cases were found by a search of the regular expression
^ using \w+PointerType = \w+Type \*;$in all "itk*.h" files.FUTURE_LEGACY_REMOVEBoundaryConditionPointerType, replace withBoundaryConditionType *#4538