FUTURE_LEGACY_REMOVE BoundaryConditionPointerType, replace with BoundaryConditionType *#4538
Merged
thewtex merged 3 commits intoInsightSoftwareConsortium:masterfrom Apr 1, 2024
Conversation
Made it clearer that ConvolutionImageFilterBase and PadImageFilterBase use a _raw_ pointer to the `BoundaryCondition`.
FFTConvolutionImageFilter does not use `BoundaryConditionPointerType`.
github-actions
bot
added
the
area:Filtering
dzenanz
approved these changes
Mar 27, 2024
It appears much clearer to directly use `BoundaryConditionType *`, to explicitly make clear when using a _raw_ pointer, rather than a _smart_ pointer. Note that the BoundaryConditionPointerType aliases of PadImageFilter and FFTPadImageFilter were unnecessary anyway, as they might be inherited from their base class, PadImageFilterBase.
N-Dekker
force-pushed
the
FUTURE_LEGACY_REMOVE-BoundaryConditionPointerType
branch
from
a33368f to
226802f
Compare
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Apr 2, 2024
Deprecated `InternalPixelPointerType`, which appears unused and untested anyway. Follow-up to pull request InsightSoftwareConsortium#4538 commit f44304d "STYLE: FUTURE_LEGACY_REMOVE BoundaryConditionPointerType type aliases"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Apr 2, 2024
Follow-up to pull request InsightSoftwareConsortium#4538 commit f44304d "STYLE: FUTURE_LEGACY_REMOVE BoundaryConditionPointerType type aliases"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Apr 2, 2024
Deprecated `DiscreteGaussianImageFilter::InputBoundaryConditionPointerType`. Follow-up to pull request InsightSoftwareConsortium#4538 commit f44304d "STYLE: FUTURE_LEGACY_REMOVE BoundaryConditionPointerType type aliases"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BoundaryConditionPointerTypeis just a type alias forBoundaryConditionType *. It appears much clearer to directly useBoundaryConditionType *, to explicitly make clear when using a raw pointer, rather than a smart pointer.