STYLE: Revert C++14 workaround when using the constexpr SupportSize#4603
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom May 20, 2024
Conversation
C++17 allows using a static constexpr member variable like `SupportSize`, without being "redeclared". The workaround of copying `SupportSize` into a local variable is no longer necessary. Reverts pull request InsightSoftwareConsortium#2742 commit 27e4815 "COMP: Copy BSplineInterpolationWeightFunction::SupportSize within lambda"
github-actions
bot
added
area:Core
thewtex
approved these changes
Apr 21, 2024
Member
thewtex
left a comment
thewtex
left a comment
There was a problem hiding this comment.
👍
Please wait until after v5.4.0 to merge.
Contributor
Author
Thanks Matt. I think this pull request is ready, but I marked it "draft" to prevent getting merged accidentally, before v5.4.0. |
Member
|
@N-Dekker perfect! 🙏 |
Member
|
@N-Dekker v5.4.0 has been tagged 🚀 🧑🎤 -- we can merge these drafts when ready. |
This was referenced May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++17 allows using a static constexpr member variable like
SupportSize, without being "redeclared". The workaround of copyingSupportSizeinto a local variable is no longer necessary.Reverts pull request #2742 commit 27e4815
"COMP: Copy BSplineInterpolationWeightFunction::SupportSize within lambda"