forked from aws/aws-cdk
    
        
        - 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
get the last data #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    ### Issue # (if applicable) No ### Reason for this change Generating the metafile in a Windows environment can fail when the path are not enclosed with quotes. ### Description of changes #### What code changes did you make? Enclosed paths the bundling arguments `--metafile` and `--tsconfig` #### Have you made any important design decisions? No #### What AWS use cases does this change enable? To enable the use cases, which AWS service features are utilized? Allows safe usage of `metafile` and `tsconfig` bundling options ### Describe any new or updated permissions being added <!— What new or updated IAM permissions are needed to support the changes being introduced ? --> ### Description of how you validated changes #### Have you added any unit tests and/or integration tests? No, but when you have a project path with a whitespace, and use the `metafile` bundling argument, the metafile path should be passed correctly within quotes to esbuild. I updated the existing tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Reason for this change For `eks-v2` module, it uses `API` as authentication mode which means access entries will be used to replace aws-auth ConfigMap. `awsAuth` construct is not used anymore. ### Description of changes - `authenticationMode` is removed from L2 because the only authentication mode allowed is `API`. The value is hardcode when creating the L1 resource. - Remove `awsAuth` and its usage in the new module ### Description of how you validated changes unit tests ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…32998) ### Reason for this change We are publishing the `cx-api` package twice: Once as a standalone package `@aws-cdk/cx-api` and once as part of the construct library under `aws-cdk-lib/cx-api`. The code is copied during the release and the same versions of the packages will have the same code. However this makes it difficult for other packages to take a type dependency on types from this package. The most common class that's used from `cx-api` is `CloudAssembly` - the result of `app.synth()`. Previously a package had to take a dependency on the very large `aws-cdk-lib` just to use a single type. It would be better if other packages could instead depend on the smaller, much more focused `@aws-cdk/cx-api` package. ### Description of changes This adds the same mechanism to `CloudAssembly` to detect cross-library compatibility, that we already use for constructs like `Stack` or `App`. In TypeScript, it's now possible for a consuming package to receive an object from either package and check at runtime if it satisfies the requirements. We cannot get around type checking with this. Instead we introduce a new type `ICloudAssembly` into the Cloud Assembly Schema package (cdklabs/cloud-assembly-schema#133). This interface only declares a single property: `directory`. Consumers can use this type to indicate where they would like to receive a `CloudAssembly`. They can then use runtime code to either confirm a provided object already satisfies the requirements or fallback to creating a new `CloudAssembly` from the directory. Because the `CloudAssembly` in `cxapi` implements the new interface, this approach will work in all jsii languages. In TypeScript it's even compatible with older version of `aws-cdk-lib`. Jsii language will only support this going forward. #### Allowed breaking changes ``` weakened:aws-cdk-lib.cloud_assembly_schema.MetadataEntry weakened:aws-cdk-lib.cx_api.MetadataEntryResult ``` This PR updates the version of `@aws-cdk/cloud-assembly-schema` to make new of the new interface. However the update also includes a change to `MetadataEntry` which was introduced in cdklabs/cloud-assembly-schema#121. That change is weakening a type, because in #31041, the CDK started emitting booleans and numbers as metadata values. But since these types weren't officially declared in the schema, jsii runtime type checking failed to load them. The fix was to officially extend the type union to include `boolean` and `number` primitive values. This is considered breaking, because when used as an output any consuming code will now need to account for the possibility of the value being a `boolean` or `number`. In static languages, the type would already have been treated as a generic Object with required runtime checks. ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Unit tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue `aws-s3` for #32569 ### Description of changes Added an `UnscopedValidationError` for situations where now scope is available. This is to be used sparsely as it's less useful for users. ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Existing tests. Exemptions granted as this is basically a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue `aws-lambda` for #32569 ### Description of changes Updated thrown errors. ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Existing tests. Exemptions granted as this is basically a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#32521) ### Issue # (if applicable) Implementation of [RFC 0497](https://github.com/aws/aws-cdk-rfcs/blob/main/text/0497-glue-l2-construct.md) ### Reason for this change Refactored glue-alpha construct to enforce validations by contract and interfaces, improve developer experience, and adhere to best practices. [Related PR with merge conflicts and history](mjanardhan#12) ### Description of changes Refactored from a single Job class to a pattern of inheritance that removes the need for synth-time validations and sets best practice defaults. Allows for overriding language and Glue versions where applicable, and other job-type specific parameters. The existing Job and Job Executable monoliths have been decomposed into Job Type and Language specific classes that implement and extend an abstract Job parent class. Developers will be able to see mandatory and optional parameters that apply just to their selected job type and language, rather than having to reference documentation and examples or find out during synth or deploy time that they've selected the wrong configuration. BREAKING CHANGE: Developers must refactor their existing Job instantiation method calls to choose the right job type and language, and use the new constants static values to define the associated Job configuration settings. See the RFC and/or new README for examples. ### Description of how you validated changes Increased unit test coverage to > 90%, consulted with Glue service team on best practices and sane defaults, updated integration tests. ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --------- Co-authored-by: Janardhan (Janny) Molumuri <[email protected]> Co-authored-by: GZ <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
### Issue # (if applicable) Closes NA ### Reason for this change New Github actions workflows to add PRs automatically to the Priority Project board based on the existing labels. ### Description of changes The Github priority project board will be used internally by the CDK team to have a single consolidated view of all PR's based on the priority category. This change will enable github action workflow to automate adding PRs to the priority board. ### Describe any new or updated permissions being added N/A ### Description of how you validated changes Ran unit test and test in local repo. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixing some fast-follow items from the recent glue PR that was merged. there is more work to be done specifically around the README but I see this as the minimum amount of changes to make glue-alpha somewhat consistent with the rest of the modules we offer in cdk, alpha or not ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes #<issue number here>. ### Reason for this change This PR adds new fields under VPCv2 construct to add BYOIP using AWS pool id and CIDR range of the IPv6 address. ### Description of changes ### Describe any new or updated permissions being added No update to permissions. ### Description of how you validated changes Added unit test and integration test. To test these changes in future, users will need to modify the pool-id with the one hosted in their account and run integration test. For internal testing, instructions added to [team-internal docs](cdklabs/team-internal#269) with pool onboarding details. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) None ### Reason for this change Fixed typos in code comments. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) None ### Reason for this change Fixed typo in code comment. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) None ### Reason for this change Fixed typos in code comments. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Bumps [jsii](https://github.com/aws/jsii-compiler) from 5.4.36 to 5.7.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/jsii-compiler/releases">jsii's releases</a>.</em></p> <blockquote> <h2>v5.7.4</h2> <h2>What's Changed</h2> <ul> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1602">aws/jsii-compiler#1602</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1605">aws/jsii-compiler#1605</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1608">aws/jsii-compiler#1608</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1611">aws/jsii-compiler#1611</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/aws/jsii-compiler/compare/v5.7.3...v5.7.4">https://github.com/aws/jsii-compiler/compare/v5.7.3...v5.7.4</a></p> <h2>v5.7.3</h2> <h2>What's Changed</h2> <ul> <li>chore: <code>Match.arrEq</code> is not defined for arrays containing <code>undefined</code> by <a href="https://github.com/rix0rrr"><code>@rix0rrr</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1589">aws/jsii-compiler#1589</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1593">aws/jsii-compiler#1593</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1596">aws/jsii-compiler#1596</a></li> <li>fix: use maps instead of literals in <code>configureCategories</code> by <a href="https://github.com/iliapolo"><code>@iliapolo</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1598">aws/jsii-compiler#1598</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/aws/jsii-compiler/compare/v5.7.2...v5.7.3">https://github.com/aws/jsii-compiler/compare/v5.7.2...v5.7.3</a></p> <h2>v5.7.2</h2> <h2>What's Changed</h2> <ul> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1536">aws/jsii-compiler#1536</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1540">aws/jsii-compiler#1540</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1544">aws/jsii-compiler#1544</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1548">aws/jsii-compiler#1548</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1552">aws/jsii-compiler#1552</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1560">aws/jsii-compiler#1560</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1564">aws/jsii-compiler#1564</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1568">aws/jsii-compiler#1568</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1572">aws/jsii-compiler#1572</a></li> <li>fix: <code>lib</code> setting from custom config is ignored by <a href="https://github.com/rix0rrr"><code>@rix0rrr</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1576">aws/jsii-compiler#1576</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1580">aws/jsii-compiler#1580</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1585">aws/jsii-compiler#1585</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/aws/jsii-compiler/compare/v5.7.1...v5.7.2">https://github.com/aws/jsii-compiler/compare/v5.7.1...v5.7.2</a></p> <h2>v5.7.1</h2> <h2>What's Changed</h2> <ul> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1520">aws/jsii-compiler#1520</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1524">aws/jsii-compiler#1524</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1528">aws/jsii-compiler#1528</a></li> <li>chore(deps): upgrade dependencies by <a href="https://github.com/aws-cdk-automation"><code>@aws-cdk-automation</code></a> in <a href="https://github.com/aws/jsii-compiler/pull/1532">aws/jsii-compiler#1532</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/aws/jsii-compiler/compare/v5.7.0...v5.7.1">https://github.com/aws/jsii-compiler/compare/v5.7.0...v5.7.1</a></p> <h2>v5.7.0</h2> <h2>What's Changed</h2> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/jsii-compiler/commit/fc2a28e717f5f35062b38acc027d02f950e21b22"><code>fc2a28e</code></a> chore(deps): upgrade dependencies (<a href="https://github.com/aws/jsii-compiler/issues/1611">#1611</a>)</li> <li><a href="https://github.com/aws/jsii-compiler/commit/cad43946e228acf8cb5392cbf089aafa3d72fe39"><code>cad4394</code></a> chore(deps): upgrade dependencies (<a href="https://github.com/aws/jsii-compiler/issues/1608">#1608</a>)</li> <li><a href="https://github.com/aws/jsii-compiler/commit/81c223feb14b483471f7dc31445934fc9729dfbe"><code>81c223f</code></a> chore(deps): upgrade dependencies (<a href="https://github.com/aws/jsii-compiler/issues/1605">#1605</a>)</li> <li><a href="https://github.com/aws/jsii-compiler/commit/3300635de5650156fb1d7a187f7de4fd7c7fab04"><code>3300635</code></a> chore(deps): upgrade dependencies (<a href="https://github.com/aws/jsii-compiler/issues/1602">#1602</a>)</li> <li><a href="https://github.com/aws/jsii-compiler/commit/e7089ad9d257bc19899c5b12abeaff8389a58ee8"><code>e7089ad</code></a> fix: use maps instead of literals in <code>configureCategories</code> (<a href="https://github.com/aws/jsii-compiler/issues/1598">#1598</a>)</li> <li><a href="https://github.com/aws/jsii-compiler/commit/3704ae6c4ef8d8143b47c6957432ae9d06a727e6"><code>3704ae6</code></a> chore(deps): upgrade dependencies (<a href="https://github.com/aws/jsii-compiler/issues/1596">#1596</a>)</li> <li><a href="https://github.com/aws/jsii-compiler/commit/0d5767befb2573abcc849188a9b38dcec6cdc75a"><code>0d5767b</code></a> chore(deps): upgrade dependencies (<a href="https://github.com/aws/jsii-compiler/issues/1593">#1593</a>)</li> <li><a href="https://github.com/aws/jsii-compiler/commit/4f3e87ea5e142a02ac5c69ad0777200df8eac588"><code>4f3e87e</code></a> chore: <code>Match.arrEq</code> is not defined for arrays containing <code>undefined</code> (<a href="https://github.com/aws/jsii-compiler/issues/1589">#1589</a>)</li> <li><a href="https://github.com/aws/jsii-compiler/commit/224a3f34fd260a9c5ea2b877633536857b2fe973"><code>224a3f3</code></a> chore(deps): upgrade dependencies (<a href="https://github.com/aws/jsii-compiler/issues/1585">#1585</a>)</li> <li><a href="https://github.com/aws/jsii-compiler/commit/f393cd3a8e92e16e633afd1d47961d33899b8892"><code>f393cd3</code></a> chore(deps): upgrade dependencies (<a href="https://github.com/aws/jsii-compiler/issues/1580">#1580</a>)</li> <li>Additional commits viewable in <a href="https://github.com/aws/jsii-compiler/compare/v5.4.36...v5.7.4">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/aws/aws-cdk/network/alerts). </details>
Bumps [undici](https://github.com/nodejs/undici) from 5.28.4 to 5.28.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/nodejs/undici/releases">undici's releases</a>.</em></p> <blockquote> <h2>v5.28.5</h2> <h1>⚠️ Security Release⚠️ </h1> <p>Fixes CVE CVE-2025-22150 <a href="https://github.com/nodejs/undici/security/advisories/GHSA-c76h-2ccp-4975">https://github.com/nodejs/undici/security/advisories/GHSA-c76h-2ccp-4975</a> (embargoed until 22-01-2025).</p> <p><strong>Full Changelog</strong>: <a href="https://github.com/nodejs/undici/compare/v5.28.4...v5.28.5">https://github.com/nodejs/undici/compare/v5.28.4...v5.28.5</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/nodejs/undici/commit/6139ed2e0c787853243de58ef7c4301b26ca66f2"><code>6139ed2</code></a> Bumped v5.28.5</li> <li><a href="https://github.com/nodejs/undici/commit/711e20772764c29f6622ddc937c63b6eefdf07d0"><code>711e207</code></a> Backport of c2d78cd</li> <li>See full diff in <a href="https://github.com/nodejs/undici/compare/v5.28.4...v5.28.5">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/aws/aws-cdk/network/alerts). </details>
### Issue # (if applicable) None ### Reason for this change Fixed typos in code comments. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) None ### Reason for this change Fixed typo in code comment. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Waiter errors now have an additional piece of information: the responses that were observed during the polling, and their counts. Relay this information to the user in the error message. Closes #32481. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…oc (#33048) Updated JSDoc for Spark and Python versions used in Glue 5.0. Ref: https://docs.aws.amazon.com/glue/latest/dg/release-notes.html ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) None ### Reason for this change Fixed a typo in a function name in code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue `aws-rds` for #32569 ### Description of changes ValidationErrors everywhere ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Existing tests. Exemptions granted as this is basically a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue `aws-sns` for #32569 ### Description of changes ValidationErrors everywhere ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Existing tests. Exemptions granted as this is basically a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Some fixture cleanup: - `withCdkMigrateApp` was needlessly creating its own instance of `AwsClients` instead of reusing the one created by the `withAws` fixture. - `withMonolithicCfnIncludeCdkApp` is no longer necessary because we now have `withSpecificFixture` which can use a non default app. This will make it easier to introduce the allocation service logic as there is now only a single place that creates `AwsClients` ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The fixture wasn't ensuring a bootstrapped environment ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue `aws-sqs` for #32569 ### Description of changes ValidationErrors everywhere ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Existing tests. Exemptions granted as this is basically a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes NA ### Reason for this change New Github actions workflows to add PRs automatically to the Priority Project board based on the existing labels. ### Description of changes The Github priority project board will be used internally by the CDK team to have a single consolidated view of all PR's based on the priority category. This change will enable github action workflow to automate adding PRs to the priority board. ### Describe any new or updated permissions being added N/A ### Description of how you validated changes Ran unit test and test in local repo. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue `aws-ssm` + friends for #32569 ### Description of changes ValidationErrors everywhere ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Existing tests. Exemptions granted as this is basically a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
After the version upgrade of `@aws-cdk/cloud-assembly-schema` to `^39.2.0` in #32998 our cli integration and init tests started failing with the following error in all .NET projects: ``` /tmp/CdkInteg0Rk0Rq9U2Tk.csproj : error NU1605: Warning As Error: Detected package downgrade: Amazon.JSII.Runtime from 1.106.0 to 1.104.0. Reference the package directly from the project to select a different version. /tmp/CdkInteg0Rk0Rq9U2Tk.csproj : error NU1605: CdkInteg0Rk0Rq9U2Tk -> Amazon.CDK.Lib 2.177.0-rc.0 -> Amazon.CDK.CloudAssembly.Schema 39.2.0 -> Amazon.JSII.Runtime (>= 1.106.0 && < 2.0.0) /tmp//CdkInteg0Rk0Rq9U2Tk.csproj : error NU1605: CdkInteg0Rk0Rq9U2Tk -> Amazon.CDK.Lib 2.177.0-rc.0 -> Amazon.JSII.Runtime (>= 1.104.0 && < 2.0.0) ``` ### Reason for this change This error is documented in the NuGet docs as [Example 1](https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1605#example-1). The .NET CDK project that is created in these tests declares a dependency on depending on `Amazon.CDK.Lib`. `Amazon.CDK.Lib` declares a direct dependency on `Amazon.JSII.Runtime (>= 1.104.0 && < 2.0.0)`. But it also declares an indirect dependency on `Amazon.JSII.Runtime (>= 1.106.0 && < 2.0.0)` through the `Amazon.CDK.CloudAssembly.Schema` package: ``` TestProject -> Amazon.CDK.Lib 2.177.0-rc.0 -> Amazon.CDK.CloudAssembly.Schema 39.2.0 -> Amazon.JSII.Runtime (>= 1.106.0 && < 2.0.0) TestProject -> Amazon.CDK.Lib 2.177.0-rc.0 -> Amazon.JSII.Runtime (>= 1.104.0 && < 2.0.0) ``` Because of the [direct-dependency-wins](https://learn.microsoft.com/en-us/nuget/concepts/dependency-resolution#direct-dependency-wins) rule `Amazon.JSII.Runtime (>= 1.104.0 && < 2.0.0)` would be selected. It overrules the distant package and thus causes the package downgrade, which is an error. #### Why does the issue surface now? The previous (released) version of `Amazon.CDK.Lib` declares these dependencies ([Source](https://www.nuget.org/packages/Amazon.CDK.Lib/2.176.0#dependencies-body-tab)): ``` Amazon.CDK.CloudAssembly.Schema (>= 39.0.1 && < 40.0.0) Amazon.JSII.Runtime (>= 1.104.0 && < 2.0.0) ``` And `Amazon.CDK.CloudAssembly.Schema` v39.0.1 declares this dependency ([Source](https://www.nuget.org/packages/Amazon.CDK.CloudAssembly.Schema/39.0.1#dependencies-body-tab)): ``` Amazon.JSII.Runtime (>= 1.104.0 && < 2.0.0) ``` As you can see, both versions of `Amazon.JSII.Runtime` are the same. The pre-released package of `Amazon.CDK.Lib` however has updated its dependency on `Amazon.CDK.CloudAssembly.Schema` to `(>= 39.2.0 && < 40.0.0)`. And if we check the distant dependencies for the newer version of `Amazon.CDK.CloudAssembly.Schema`, we get this ([Source](https://www.nuget.org/packages/Amazon.CDK.CloudAssembly.Schema/39.2.0#dependencies-body-tab)): ``` Amazon.JSII.Runtime (>= 1.106.0 && < 2.0.0) ``` **This is where the problem stems from.** #### Root cause The dependency constraint for `Amazon.JSII.Runtime` is determined by the used version of `jsii-pacmak` in each package. The root cause is that the tested versions of `aws-cdk-lib` and `@aws-cdk/cloud-assembly-schema` are build with a different version of `jsii-pacmak`. ### Description of changes Update the version of `jsii-pacmak` in all monorepo packages to be the latest version and the same as in `@aws-cdk/cloud-assembly-schema`. ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Run through the integration test pipeline. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) None ### Reason for this change Fixed typos in code comments. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes #29711. ### Reason for this change The actual IOPS limit depends on a few factors:  Therefore, It is not trivial to maintain the limit checks in CDK. In addition, when the the service changes the limit, the CDK outdated limits will be a blocker for users to use the new limits. All in all, this check creates blockers more than benefit. ### Description of changes Removed the limit check on IOPS. ### Description of how you validated changes Unit Test that were expecting the error was failing after the removal of the check. Removed those test. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes #32362. ### Reason for this change This change allows users to specify the networking primitives for an EKS Hybrid nodes cluster through L2 constructs. ### Description of changes This PR introduces two new top-level fields called `remoteNodeNetworks` and `remotePodNetworks` in the Cluster construct. Together, these allow users to specify the exact CIDRs ranges they want to use for their on-premises nodes and (optionally) pods. The Hybrid nodes feature requires that none of the node and pod CIDRs overlap with each other so I have also added validations for that. ### Description of how you validated changes Added unit tests with different testcases involving different remote network configurations. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue #33394 Closes #33394 ### Reason for this change In #32354 we started logging credentials provided by a plugin to `stderr`. In #32708 we changed the log statement in a way that the credentials would be logged to `stdout` in CI environments (but still to `stderr` in all other environments). ### Description of changes Do not log credentials. ### Describe any new or updated permissions being added n/a ### Description of how you validated changes n/a ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
See CHANGELOG
### Issue Relates to #32569 ### Description of changes `ValidationErrors` everywhere ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Existing tests. Exemptions granted as this is a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…33388) ### Issue Relates to #32569 ### Description of changes `ValidationErrors` everywhere ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Existing tests. Exemptions granted as this is a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The test is failing for a reason unrelated to the code introduced in the patch. It is also failing in our regular canaries. This is a last resort PR to bypass the test and release the patch, if we are unable to quickly fix the test.
…33390) ### Issue Relates to #32569 ### Description of changes `ValidationErrors` everywhere ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Existing tests. Exemptions granted as this is a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ped Errors (#33391) ### Issue Relates to #32569 ### Description of changes `ValidationErrors` everywhere ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Existing tests. Exemptions granted as this is a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Reason for this change When checking out a fresh copy of the repo you are currently greeted with this message: ``` Encountered 32 file(s) that should have been pointers, but weren't: [list of the 32 files] ``` Additionally, when changing branches or updating branches some of these files frequently end up in a state that is confusing git, thus making it almost impossible to with the repo. It appears that these files have not been migrated to lfs correctly. ### Description of changes Run the following command to fix the files: `git lfs migrate import --no-rewrite [list of the 32 files]` ### Describe any new or updated permissions being added n/a ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
#33411) Add missing engine versions. Ref: https://aws.amazon.com/about-aws/whats-new/2025/02/amazon-rds-oracle-january-2025-release-update/ ```sh % aws rds describe-db-engine-versions \ --region us-east-1 \ --query "DBEngineVersions[?EngineVersion=='19.0.0.0.ru-2025-01.rur-2025-01.r1' || EngineVersion=='21.0.0.0.ru-2025-01.rur-2025-01.r1'].[Engine, EngineVersion, Status]" \ --output table ----------------------------------------------------------------------- | DescribeDBEngineVersions | +-----------------+--------------------------------------+------------+ | oracle-ee | 19.0.0.0.ru-2025-01.rur-2025-01.r1 | available | | oracle-ee-cdb | 19.0.0.0.ru-2025-01.rur-2025-01.r1 | available | | oracle-ee-cdb | 21.0.0.0.ru-2025-01.rur-2025-01.r1 | available | | oracle-se2 | 19.0.0.0.ru-2025-01.rur-2025-01.r1 | available | | oracle-se2-cdb | 19.0.0.0.ru-2025-01.rur-2025-01.r1 | available | | oracle-se2-cdb | 21.0.0.0.ru-2025-01.rur-2025-01.r1 | available | +-----------------+--------------------------------------+------------+ ``` ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…lambda function (#33372) ### Improves testing for #33322. ### Reason for this change The original test (removed below) does not adequately test the CDK import fix from the above-mentioned PR. It calls CDK synth, but does not use the CLI and does not test `cdk import`. ### Description of changes The old test is removed. The new test ensures that `cdk import` works when an already-deployed stack contains a NodeJSFunction lambda. In our test, we deploy a stack containing a NodeJSFunction Lambda. We also create, orphan, and import an S3 bucket, which replicates the customer scenario in issue #31999. The test: 1. Installs `esbuild` so that we can use it for bundling. 2. Deploys a NodeJSFunction and an S3 bucket. 3. Orphans the S3 bucket but allows the bucket to persist (not destroyed). 4. Imports the S3 bucket into the template using its `BucketName` property. The test will fail if the import operation fails for any reason. The test does not assert any specific values or patterns for asset metadata keys. When investigating the issue, the metadata keys were different when using import-synth (skipped bundling) and deploy/diff/synth (did not skip bundling). The difference in the keys was another symptom of the same issue. ### Describe any new or updated permissions being added No permissions changes. ### Description of how you validated changes This PR tests the feature. I ensured that the test failed on code prior to the change in PR #33322, and passes on code following the change. ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue Relates to #32569 ### Description of changes Introduces a new `AssertionError` and uses it. ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Existing tests. Exemptions granted as this is a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes #31831. ### Reason for this change The `kubectl` custom resource lambda was not correctly passing the `skipCrds` parameter of `aws_eks.Cluster.addHelmChart` all the way through to the invocation of `helm`. As such, unexpected behaviour was observed where, even if `skipCrds` was `true`, `helm` running within the lambda would still attempt to install any relevant CRDs as part of the chart. ### Description of changes Adds the `skip_crds` argument to the call to `helm` within the `helm_handler` function. ### Description of how you validated changes I've run the unit tests and verified no changes. I cannot run the integration tests as I cannot afford the cost of deploying a full EKS cluster into my personal AWS account and I can't link this PR to our org's GitHub as per your guidelines, so I can't deploy into an account our org owns through CI. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The lastest cdk-assets is required in cdk to mitigate a ECR upload issue. It includes the following fix: cdklabs/cdk-assets#342. The following issues are related to this: #30258 #31549 #33264 I am keeping #31549 open as it is still true. this [feature request](cdklabs/cdk-assets#348) tracks the work to make cdk-assets compatible with containerd Closes #30258 and closes #33264
We've moved some files around and the generated files point to the wrong place for the source of truth
### Issue #32217 Closes #32217. ### Reason for this change ECS targets can override any item in the [`TaskOverride` structure](https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_TaskOverride.html) via the `input` parameter, according to [the docs](https://docs.aws.amazon.com/eventbridge/latest/userguide/eb-targets.html#targets-specifics-ecs-task). However, today, only the `containerOverrides` option is exposed: https://github.com/aws/aws-cdk/blob/1b7265bf5cc623b2e362266c96ce866df539581f/packages/aws-cdk-lib/aws-events-targets/lib/ecs-task.ts#L225-L227 ### Description of changes This PR adds all `TaskOverride` properties to the `input` parameter. ### Description of how you validated changes I add unit tests. I also updated the existing integration tests to include additional overrides. I validated them in my AWS account. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Appears that the underlying issue failing this test has been resolved. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
On GitHub Actions the `jest` test run doesn't exit because it is being kept alive. The reason is that we create a `CloudWatchLogMonitor` in one test, which keeps on scheduling a timer with `setTimeout()` which keeps the Node process alive. I'm not sure why this doesn't manifest on the CodeBuild build or a Mac laptop run, but it can be somewhat reproduced by running `npx jest --detectOpenHandles`, which *does* make the test hang on Mac as well. I considered `unref()`fing the timer, but it seems a smaller and therefore safer change to take the `CloudWatchLogMonitor` and deactivate it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Reason for this change Randomizing tests is good practice to ensure test cases are written in a self-contained way. ### Description of changes Enable randomizing tests and fix mocks that were dependent on state. Also increase minimum coverage thresholds to match current reality. ### Describe any new or updated permissions being added n/a ### Description of how you validated changes existing tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
| 
           Comments on closed issues and PRs are hard for our team to see.  | 
    
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Issue # (if applicable)
Closes #.
Reason for this change
Description of changes
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license