@aws-cdk/aws-eks: cluster.addHelmChart doesn't pass SkipCrds

[dancmeyers]

Describe the bug

The kubectl custom resource handler has a special path for handling helm charts. This path has a property for SkipCrds, which should do as expected:

aws-cdk/packages/@aws-cdk/custom-resource-handlers/lib/aws-eks/kubectl-handler/helm/__init__.py

Line 55 in 318eae6

skip_crds = props.get('SkipCrds', False)

The helm function also accepts a skip_crds argument:

aws-cdk/packages/@aws-cdk/custom-resource-handlers/lib/aws-eks/kubectl-handler/helm/__init__.py

Line 161 in 318eae6

def helm(verb, release, chart = None, repo = None, file = None, namespace = None, version = None, wait = False, timeout = None, create_namespace = None, skip_crds = False, atomic = False):

But the line that links the two together does not pass that argument, so it is impossible to tell cluster.addHelmChart not to install CRDs:

aws-cdk/packages/@aws-cdk/custom-resource-handlers/lib/aws-eks/kubectl-handler/helm/__init__.py

Line 94 in 318eae6

helm('upgrade', release, chart, repository, values_file, namespace, version, wait, timeout, create_namespace, atomic=atomic)

Regression Issue

• Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

Passing skipCrds to cluster.addHelmChart should bypass installing CRDs via helm.

Current Behavior

CRDs are still installed via helm even if skipCrds is given as an argument to cluster.addHelmChart.

Reproduction Steps

• Use cluster.addHelmChart to install a new helm chart that includes CRDs.
• Pass skipCrds: true as an argument to addHelmChart.
• Apply the change.
• Observe that CRDs are still installed.

Possible Solution

The source of the Python kubectl-handler lambda needs to be updated to correctly pass this argument.

Additional Information/Context

No response

CDK CLI Version

2.162.1 (build 10aa526)

Framework Version

No response

Node.js Version

20.18.0

OS

MacOS Sequoia 15.0.1

Language

TypeScript

Language Version

TypeScript (5.6.3), Python 3.11

Other information

No response

[pahud]

I just read your PR. Yes, looks like that was a miss. Thank you for the report and PR.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.