Skip to content

Conversation

@iliapolo
Copy link
Contributor

See CHANGELOG

mrgrain and others added 3 commits February 12, 2025 08:25
### Issue #33394

Closes #33394

### Reason for this change

In #32354 we started logging credentials provided by a plugin to `stderr`. In #32708 we changed the log statement in a way that the credentials would be logged to `stdout` in CI environments (but still to `stderr` in all other environments).

### Description of changes

Do not log credentials.

### Describe any new or updated permissions being added

n/a

### Description of how you validated changes

n/a

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@iliapolo iliapolo added the pr/no-squash This PR should be merged instead of squash-merging it label Feb 12, 2025
@iliapolo iliapolo requested a review from a team as a code owner February 12, 2025 06:36
@github-actions github-actions bot added the p2 label Feb 12, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 12, 2025 06:37
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 12, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@iliapolo iliapolo added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Feb 12, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 12, 2025 06:45

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0aa9e1e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 12, 2025
@mergify
Copy link
Contributor

mergify bot commented Feb 12, 2025

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit dbb07d7 into v2-release Feb 12, 2025
38 of 39 checks passed
@mergify mergify bot deleted the patch/v2.178.2 branch February 12, 2025 07:45
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr/no-squash This PR should be merged instead of squash-merging it pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants