Conversation
dd7f1e8 to
abdbabb
Compare
BastianLedererIcinga
left a comment
There was a problem hiding this comment.
The changes look good, everything should be fine once the issue with the dependencies is resolved.
|
The generation of some PDF fails, and the logs point to errors in the code related to |
6278275 to
95c65a4
Compare
95c65a4 to
799e3a9
Compare
|
To make this branch ready for merging, the |
4c6f2db to
4244956
Compare
|
We could consider replacing it with |
4244956 to
e15655e
Compare
|
I disabled the deprecation warning and tested |
|
Tested with the previously replaced lib @nilmerg if there is no important reason for the replacement, we could switch back to |
Since PHP 8.4 implicitly nullable parameter types are deprecated.
e15655e to
034c7e3
Compare
034c7e3 to
1ab4cde
Compare
lippserd
left a comment
There was a problem hiding this comment.
Please merge the two commits that are solely for cleaning up the dependency replacement made in #77. And please rephrase the commit message and description to clarify the intent:
Cleanup leftovers from dependency replacement
bc4d059 replaced dependencies but left outdated code, addressed here:
- Catch `Throwable` instead of removed `WebSocket\ConnectionException`
- Remove patch for replaced library
Please always use short commit hashes in commit descriptions instead of GitHub PR numbers, as these have no value outside of GitHub. And please do not use bullet points if there is only one point.
Please also adjust the PR description. The only changes required to support PHP 8.5 are now the fix for implicit nullable type declarations, right? I'm also not entirely sure if it makes sense to require the missing react/child-process issue, as it requires a PR in icinga-php-thirdparty that has not yet been merged. So why is the issue resolved in the first place? If this is really a strict requirement, please require the icinga-php-thirdparty PR or remove it.
bc4d059 replaced dependencies but left outdated code, addressed here: - Catch `Throwable` instead of removed `WebSocket\ConnectionException` - Remove patch for replaced library
1ab4cde to
53f546a
Compare
PHP 8.4 changes:
Other changes:
resolves #78