Conversation
A minor update of phrity/websocket is also part of this commit. Didn't bother to restrict the update…
sukhwinder33445
approved these changes
Jan 21, 2026
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
This works well on PHP 8.2–8.5. I tested this PR by merging it into the #79 branch. On PHP 8.4 and 8.5, it works when deprecation warnings are disabled (These warnings originate from the wikimedia/less package, as it has not been updated yet).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original author dropped support for PHP 8.2 early. Using our own fork, as long as we support 8.2 still, is the way to go now.
Tested successfully on: