Merged
Conversation
sukhwinder33445
force-pushed
the
support/php-85
branch
from
3cc079c to
491a9b7
Compare
sukhwinder33445
force-pushed
the
support/php-85
branch
from
491a9b7 to
0bdecb2
Compare
BastianLedererIcinga
previously approved these changes
Dec 4, 2025
tests/Lib/PromiseBoundTask.php
Outdated
| } | ||
|
|
||
| public function run(): ExtendedPromiseInterface | ||
| public function run(): PromiseInterface |
There was a problem hiding this comment.
Perhaps we should document the changed return types like this one somewhere.
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
I think it should be sufficient to mention this in the release notes? Should I create a release draft, @lippserd?
Yes, please!
sukhwinder33445
force-pushed
the
support/php-85
branch
3 times, most recently
from
d4dd640 to
979e1fd
Compare
`SplObjectStorage::contains()` => `SplObjectStorage::offsetExists()` `SplObjectStorage::attach()` => `SplObjectStorage::offsetSet()` `SplObjectStorage::detach()` => `SplObjectStorage::offsetUnset()` ref: https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.spl
sukhwinder33445
force-pushed
the
support/php-85
branch
from
979e1fd to
6d36fa6
Compare
Contributor
Author
|
To make this branch ready for merging, the |
lippserd
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made:
PHP 8.5:
No changes are required for PHP 8.4 support.
refs #56