review: test: Migrate support and testing tests to Junit5 #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
approved these changes
Jun 28, 2021
|
LGTM! |
Rohitesh-Kumar-Jain
deleted the
migrate-support-and-testing-tests-to-junit5
branch
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3919
While waiting for review on #4005 and #4006, I thought it will be nice to finish up the migration of the spoon.support.
Migration of testing tests is important because I will later work on it in the latter weeks plus, tests in the testing package can't be migrated automatically or by some tool, somebody needs to migrate them manually.
This PR just involves these two types of changes:
changing imports
In Junit5, assertThrows have been introduced so
@Test(expected = IndexOutOfBoundsException.class)isn't supported anymore.