Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: test: add test for Substitution.insertAllConstructors #4005

Merged
merged 1 commit into from
Jun 28, 2021
Merged

review: test: add test for Substitution.insertAllConstructors #4005

merged 1 commit into from
Jun 28, 2021

Conversation

Rohitesh-Kumar-Jain
Copy link
Contributor

#1818

Hi, I have added a new test for insertAllConstructor method of the Substitution class, following are the features of this test:

  1. This new test is killing this mutation :

Screenshot 2021-06-24 at 3 42 23 PM

  1. This method had some code coverage but, the test strength and mutation coverage was zero, now code coverage has improved and the mutation has been killed by this new test.

Screenshot 2021-06-24 at 3 43 44 PM

  1. this test improves code coverage, mutation converge and test strength all from 0% to 100% for insertConstructor method.

Screenshot 2021-06-24 at 3 49 39 PM

Link to #3967

@slarse
Copy link
Collaborator

slarse commented Jun 25, 2021

Hi @Rohitesh-Kumar-Jain,

Just an FYI I'm on vacation and won't be reviewing pull requests until monday. Perhaps @nharrand or @monperrus can find the time to look at this, but otherwise I'll get to it on Monday. Feel free to submit more PRs in parallel if you'd like.

Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slarse slarse merged commit a3a5f8f into INRIA:master Jun 28, 2021
@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain deleted the add-test-for-insertallconstructors branch June 28, 2021 07:33
@monperrus monperrus mentioned this pull request Aug 19, 2021
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants