Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: test: add tests for the SpoonTreeBuilder class #4006

Merged
merged 2 commits into from
Jun 28, 2021
Merged

review: test: add tests for the SpoonTreeBuilder class #4006

merged 2 commits into from
Jun 28, 2021

Conversation

Rohitesh-Kumar-Jain
Copy link
Contributor

#1818

Hi, I have created a new class SpoonTreeBuilderTest for the SpoonTreeBuilder class, as per Descartes's report the testing for this class was zero in all parameters hence tests were to be written from scratch.

Report before these tests :

Screen Shot 2021-06-26 at 23 01 07-fullpage

These tests improve the line coverage from 0 to 60% and improve mutation coverage and strength to 60% as well.

There are testing methods enter, exit, create node.

Link to #3967

@Rohitesh-Kumar-Jain
Copy link
Contributor Author

@nharrand, @monperrus I would be glad to know if you may suggest how we can make this test better and stronger.

@nharrand
Copy link
Collaborator

LGTM.

@nharrand nharrand merged commit fb5a7c0 into INRIA:master Jun 28, 2021
@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain deleted the add-test-for-spoontreebuilder-class branch June 28, 2021 09:43
@monperrus monperrus mentioned this pull request Aug 19, 2021
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants