Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy script #97

Merged
merged 4 commits into from
Mar 13, 2019
Merged

Update deploy script #97

merged 4 commits into from
Mar 13, 2019

Conversation

modos189
Copy link
Contributor

@modos189 modos189 commented Feb 8, 2019

Migration scripts for deployment in localbuildsettings.py.
Fix update URL/downloadURL #32 #53 #86

Commit to master leads to release build and upload to site.
Creating a new GitHub Release leads to build release version, uploading to site and attaching archives to GitHub Release #56

Fix update URL/downloadURL IITC-CE#32 IITC-CE#53 IITC-CE#86

Commit to master leads to release build and upload to site.
Creating a new GitHub Release leads to build release version, uploading to site and attaching archives to GitHub Release IITC-CE#56
@modos189 modos189 changed the title Migration scripts for deployment in localbuildsettings.py. Update deploy script Feb 8, 2019
@johnd0e
Copy link
Contributor

johnd0e commented Feb 13, 2019

After I've pulled it into test-builds branch I saw that both jobs started:

  • Test-builds
  • Release

As I was not sure that it is intended I just cancelled Release job in order to prevent deploy.

@johnd0e johnd0e added development general development issue ATTENTION Feedback required labels Feb 14, 2019
@modos189
Copy link
Contributor Author

Fixed on second attempt =(

@modos189 modos189 removed the ATTENTION Feedback required label Feb 15, 2019
@johnd0e
Copy link
Contributor

johnd0e commented Feb 23, 2019

There is unneeded additional slash in url, see e.g. https://iitc.modos189.ru/build/test/plugins/reso-energy-pct-in-portal-detail.user.js

// @updateURL      https://iitc.modos189.ru/build/test//plugins/reso-energy-pct-in-portal-detail.meta.js
// @downloadURL    https://iitc.modos189.ru/build/test//plugins/reso-energy-pct-in-portal-detail.user.js

@johnd0e johnd0e added the ATTENTION Feedback required label Feb 23, 2019
@johnd0e johnd0e removed the development general development issue label Feb 25, 2019
@modos189
Copy link
Contributor Author

modos189 commented Mar 1, 2019

Fixed

@johnd0e johnd0e removed the ATTENTION Feedback required label Mar 1, 2019
@modos189 modos189 merged commit 9e478c9 into IITC-CE:master Mar 13, 2019
@modos189 modos189 deleted the update-deploy branch March 13, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants