Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: fix update urls (sample) #53

Closed
wants to merge 1 commit into from

Conversation

johnd0e
Copy link
Contributor

@johnd0e johnd0e commented Jan 13, 2019

!Not to be merged
This is sample settings to address #32.

deploy.sh should be modified accordingly, as well as travis-ci script.
Actually, I think that we shouldn't really commit this localbuildsettings.py into repository.
Better if it be created at runtime, by travis-ci script.

@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 13, 2019

P.S.
Offtopic here, by in my opinion deploy.sh also shouldn't be in main repo.

@modos189
Copy link
Contributor

Offtopic here, by in my opinion deploy.sh also shouldn't be in main repo.

I wouldn't mind, but as far as I know Travis can't add files declared in the control panel

@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 15, 2019

I wouldn't mind, but as far as I know Travis can't add files declared in the control panel

But do we really need deploy.sh as separate file?
Couldn't it be just included in travis-ci script?

@modos189
Copy link
Contributor

I put it in a separate file because it's too individual commands for my site. Unlike the .travis.yml file, which can be used in forks.

@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 15, 2019

because it's too individual commands for my site

Well, choose what is best for you.
E.g. you could put deploy.sh itself at your site, and download it in travis script.

modos189 added a commit to modos189/ingress-intel-total-conversion that referenced this pull request Feb 8, 2019
Fix update URL/downloadURL IITC-CE#32 IITC-CE#53 IITC-CE#86

Commit to master leads to release build and upload to site.
Creating a new GitHub Release leads to build release version, uploading to site and attaching archives to GitHub Release IITC-CE#56
@modos189 modos189 mentioned this pull request Feb 8, 2019
@johnd0e johnd0e closed this Feb 11, 2019
modos189 added a commit that referenced this pull request Mar 13, 2019
* Migration scripts for deployment in localbuildsettings.py.
Fix update URL/downloadURL #32 #53 #86

Commit to master leads to release build and upload to site.
Creating a new GitHub Release leads to build release version, uploading to site and attaching archives to GitHub Release #56

* Build only test-builds branch and GitHub Releases
@johnd0e johnd0e deleted the fix-deploy-update-urls branch March 14, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants