Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update URL/downloadURL #32 #86

Closed
wants to merge 1 commit into from
Closed

Fix update URL/downloadURL #32 #86

wants to merge 1 commit into from

Conversation

johnd0e
Copy link
Contributor

@johnd0e johnd0e commented Feb 1, 2019

WIP
Migration scripts for deployment in localbuildsettings.py
Fix #32

@modos189
Copy link
Contributor

modos189 commented Feb 1, 2019

this starts only for test branch, so I didn't send it to master

@modos189
Copy link
Contributor

modos189 commented Feb 1, 2019

If only to combine history...

@johnd0e
Copy link
Contributor Author

johnd0e commented Feb 1, 2019

this starts only for test branch, so I didn't send it to master

That's ok, as I've created this PR only for purpose of tracking in our Project#1.
And we can remerge it into test-builds multiple times, as it goes.

If only to combine history...

What do you mean?

@johnd0e johnd0e changed the title Migration scripts for deployment in localbuildsettings.py. Fix update URL/downloadURL #32 Feb 1, 2019
modos189 added a commit to modos189/ingress-intel-total-conversion that referenced this pull request Feb 8, 2019
Fix update URL/downloadURL IITC-CE#32 IITC-CE#53 IITC-CE#86

Commit to master leads to release build and upload to site.
Creating a new GitHub Release leads to build release version, uploading to site and attaching archives to GitHub Release IITC-CE#56
@modos189 modos189 mentioned this pull request Feb 8, 2019
@johnd0e
Copy link
Contributor Author

johnd0e commented Feb 13, 2019

@modos189
Should we keep this PR?
Or close it in favor of #97?

@johnd0e johnd0e added development general development issue ATTENTION Feedback required labels Feb 14, 2019
@modos189
Copy link
Contributor

Or close it in favor of #97?

Yes, we don't need it anymore

@modos189 modos189 closed this Feb 15, 2019
@johnd0e johnd0e removed the ATTENTION Feedback required label Feb 15, 2019
@johnd0e johnd0e deleted the test branch February 22, 2019 09:23
modos189 added a commit that referenced this pull request Mar 13, 2019
* Migration scripts for deployment in localbuildsettings.py.
Fix update URL/downloadURL #32 #53 #86

Commit to master leads to release build and upload to site.
Creating a new GitHub Release leads to build release version, uploading to site and attaching archives to GitHub Release #56

* Build only test-builds branch and GitHub Releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development general development issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants