Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Settings page #1948

Closed
jackcmeyer opened this issue Mar 28, 2020 · 8 comments · Fixed by #2096
Closed

Settings page #1948

jackcmeyer opened this issue Mar 28, 2020 · 8 comments · Fixed by #2096
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on LOE - large indicates that the level of effort to complete issue is large user issue/pull request that interacts with the users module
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

🚀 Feature Proposal

As a user of HospitalRun, I would like a page where I can access my user settings and modify them if I wish.

I should see a Person icon in the top right of the Navbar. That Person icon should open up a dropdown that gives me options related to the current account that I am logged in as.

One of those options should be a "Settings" option.

When I click on that settings option, it should bring me to a route "/settings", where I will, one day, be able to change settings about my account.

Motivation

Customization of the application.
@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun Mar 28, 2020
@jackcmeyer jackcmeyer added 🚀enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions user issue/pull request that interacts with the users module labels Mar 28, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Mar 28, 2020
@jackcmeyer jackcmeyer mentioned this issue Mar 28, 2020
Closed
@sonofaforester
Copy link

I'd like to work on this issue

sonofaforester added a commit to sonofaforester/components that referenced this issue Mar 29, 2020
@sonofaforester
feat(component): icon based navbar dropdown
57e4199 
Added a navbar dropdown component that uses an icon instead of text. Required for the following
feature in hospitalrun-frontend:
HospitalRun/hospitalrun-frontend#1948 (comment)
@sonofaforester sonofaforester mentioned this issue Mar 29, 2020
Merged
@sonofaforester
Copy link

This is ready to go on my machine. I just need someone to approve the PR on the components project.

https://github.com/HospitalRun/components/pull/345

This adds a navbar component that has an icon with dropdown list that's called for in the feature.

@jackcmeyer
Copy link
Member Author

Hi @sonofaforester, the PR that you linked has been approved and merged. I've bumped the @hospitalrun/components dependency to v1.2.0, which includes the changes that you mentioned

@sonofaforester
Copy link

@jackcmeyer thanks for reviewing the PR. It seems the PR isn't completed and the changes aren't in v1.2.0. The build pipeline seems to be failing for something that I don't believe is within my control.

jackcmeyer pushed a commit to HospitalRun/components that referenced this issue Apr 8, 2020
feat(component): icon based navbar dropdown (#345)
8f07823 
Added a navbar dropdown component that uses an icon instead of text. Required for the following
feature in hospitalrun-frontend:
HospitalRun/hospitalrun-frontend#1948 (comment)

Co-authored-by: HospitalRun Bot <[email protected]>
@jackcmeyer
Copy link
Member Author

@sonofaforester you are correct. This wasn’t merged yet and was not included in the v1.2.0 release. I could have sworn that it was. Must have been tired that day.

I’ve merged it now and we’ll get a release made ASAP.

Sorry for the confusion.

ghost pushed a commit to HospitalRun/components that referenced this issue Apr 8, 2020
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
f48da58 
# [1.3.0](v1.2.0...v1.3.0) (2020-04-08)

### Features

* **component:** icon based navbar dropdown ([#345](#345)) ([8f07823](8f07823)), closes [/github.com/HospitalRun/hospitalrun-frontend/issues/1948#issue-589477927](https://github.com//github.com/HospitalRun/hospitalrun-frontend/issues/1948/issues/issue-589477927)
@jackcmeyer
Copy link
Member Author

@sonofaforester this is now in v1.3.0 https://github.com/HospitalRun/components/releases/tag/v1.3.0

@jackcmeyer jackcmeyer added the LOE - large indicates that the level of effort to complete issue is large label May 3, 2020
@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

Hi, may I take this?

@jackcmeyer jackcmeyer assigned ghost May 22, 2020
@ghost ghost mentioned this issue May 25, 2020
Merged
@ghost
Copy link

ghost commented May 26, 2020

Hi, PR is ready for your review: #2096

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on LOE - large indicates that the level of effort to complete issue is large user issue/pull request that interacts with the users module
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

feat(settings): add navbar dropdown and settings page
2 participants
@sonofaforester @jackcmeyer