This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
feat(navbar): icon based navbar dropdown #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a navbar dropdown component that uses an icon instead of text. Required for the following feature in hospitalrun-frontend: HospitalRun/hospitalrun-frontend#1948 (comment)
|
|
jackcmeyer
approved these changes
Apr 3, 2020
jackcmeyer
changed the title
fox1t
approved these changes
Apr 3, 2020
|
there seems to be a bug never seen on macos runner :/ |
ghost
pushed a commit
that referenced
this pull request
Apr 8, 2020
# [1.3.0](v1.2.0...v1.3.0) (2020-04-08) ### Features * **component:** icon based navbar dropdown ([#345](#345)) ([8f07823](8f07823)), closes [/github.com/HospitalRun/hospitalrun-frontend/issues/1948#issue-589477927](https://github.com//github.com/HospitalRun/hospitalrun-frontend/issues/1948/issues/issue-589477927)
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a navbar dropdown component that uses an icon instead of text.
Fixes #1948