Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(settings): add navbar dropdown and settings page #2096

Merged
merged 10 commits into from May 28, 2020
Merged

feat(settings): add navbar dropdown and settings page #2096

merged 10 commits into from May 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 25, 2020

Fixes #1948.

Changes proposed in this pull request:

  • Use @hospitalrun/components 1.6.0
  • Add a person icon in the Navbar at far right, which opens up a dropdown menu when clicked.
  • Add a Settings page. For now, added a language selection on the page.

Newly added dependencies with Bundlephobia links:

@vercel
Copy link

vercel bot commented May 25, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/d2mfltmkb
✅ Preview: https://hospitalrun-fr-git-fork-kumikokashii-add-navbar-dropdown-ddb51a.hospitalrun.now.sh

@gitpod-io
Copy link

gitpod-io bot commented May 25, 2020 •
edited
Loading

@ghost ghost mentioned this pull request May 26, 2020
Closed
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label May 26, 2020
@matteovivona matteovivona added this to the v2.0 milestone May 26, 2020
@matteovivona
Copy link
Contributor

@kumikokashii I updated some language codes with this PR #2095. Can you resolve conflicts?

matteovivona
matteovivona previously approved these changes May 26, 2020
View reviewed changes
@matteovivona matteovivona self-requested a review May 26, 2020 16:07
matteovivona
matteovivona previously approved these changes May 26, 2020
View reviewed changes
jackcmeyer
jackcmeyer suggested changes May 27, 2020
View reviewed changes
src/HospitalRun.tsx Show resolved Hide resolved
src/settings/Settings.tsx Outdated Show resolved Hide resolved
src/settings/Settings.tsx Outdated Show resolved Hide resolved
src/settings/Settings.tsx Outdated Show resolved Hide resolved
src/settings/Settings.tsx Outdated Show resolved Hide resolved
src/settings/Settings.tsx Outdated Show resolved Hide resolved
src/settings/Settings.tsx Outdated Show resolved Hide resolved
src/settings/Settings.tsx Show resolved Hide resolved
@jackcmeyer jackcmeyer added user issue/pull request that interacts with the users module 🚀enhancement an issue/pull request that adds a feature to the application labels May 27, 2020
jackcmeyer
jackcmeyer previously approved these changes May 28, 2020
View reviewed changes
@jackcmeyer jackcmeyer merged commit e5677fe into HospitalRun:master May 28, 2020
@ghost ghost mentioned this pull request May 30, 2020
Closed
@ghost ghost deleted the add-navbar-dropdown-and-settings-page branch June 17, 2020 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on user issue/pull request that interacts with the users module
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Settings page
2 participants
@matteovivona @jackcmeyer